: documented Oops running big-endian reiserfs on parisc architecture
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 9 lines · David S. Miller
From: Andi Kleen <[email protected]>
Date: 04 Sep 2001 11:44:30 +0200Quoted 3 lines · Jeff Mahoney
I did kick around the idea of making those macros the default accessors for the
deh_statemember (which is the only place they're used), but it unfairly penalizes arches that don't need them.
Quoted 5 lines
On archs that don't need them {get,put}_unaligned should be just normal assignments. They are certainly on i386.
I can also almost guarentee you that the x86 will sometimes not execute these bitops atomically on SMP.
It's not needed when you have another lock to protect and don't have interrupt threads.
iirc near all of reiserfs still runs under the BKL. BKL/schedule are full memory barriers.
Quoted 2 lines
What's more, you will have less QA'ing to do, since this code will always be in use and thus tested.
I think for a fs it is best to go with bigger locks and avoid the issue of atomic operations completely.
-Andi
From: Andi Kleen <[email protected]>
Date: Tue, 4 Sep 2001 12:25:24 +0200
Quoted 2 lines · David S. Miller
I can also almost guarentee you that the x86 will sometimes not execute these bitops atomically on SMP.
It's not needed when you have another lock to protect and don't have interrupt threads.
I agree completely, so therefore if moving to non-atomic bitops is an option that would be a great way to fix this reiserfs bug.
Later,
David S. Miller
[email protected]