Skip to contentSkip to conversation

cleanup gendisk handling

PATCH [email protected] 2 participants 2 messages Sep 3, 2001

lore
Share & tools
lore
#0 lore raw

From [email protected] Mon Sep 3 20:06:04 2001

Hi Linus,

as you probably know the gendisk handling in the current kernel is a horrible mess. All driver have to do the linked list handling themselves, etc..

Andries has a patchset on kernel.org that addresses most of this issues - but it does very large API changes and is thus not acceptable for 2.4.

The appended patch tries to cleanup the gendisk handling for the in-kernel driver a LOT, keeping all old APIs for posssible out-of-tree drivers.

Hmm - this looks almost identical to my patch 07. Yes, a nice patch :-)

Andries

[BTW - I don't think the API changes are so large. Now patch 01 has been applied.
Something very similar to 02 seems also a good candidate. Maybe I have time Friday or Saturday to rediff.]

#1 lore raw
Quoted 3 lines · On Mon, Sep 03, 2001 at 06:35:25PM +0000, [email protected] wrote:

Hmm - this looks almost identical to my patch 07.
Yes, a nice patch :-)

Although this patch is obviously inspired by your patch, there is a number of small differnces:

* I do not have the major argument to add_gendisk/del_gendisk that you remove again in one of your later patches
* I don't mess at all with the array of gendisks - that is a 2.5 issue.
* I move all gendisk handling to drivers/block/genhd.c
* I do not inline theseslow-path routines :)

Christoph

Signature · 1 line
Of course it doesn't work. We've performed a software upgrade.