Skip to contentSkip to conversation

New SCSI subsystem in 2.4, and scsi idle patch

DISCUSSION Phillip Susi 5 participants 6 messages Sep 9, 2001 – Sep 10, 2001

lore
Share & tools
lore
#0 lore raw

I'm trying to get my 2.4.9 system to spin down my scsi disk(s) when idle. Aparently, this is supported on IDE disks, but not SCSI. I found an old patch to add support for this to the 2.0.34 kernel, and have been trying to use it as a guide to fixing the 2.4.9 kernel. It seems that major changes have been done to the scsi layer, so I'm a little confused. Any help is appreciated. Here is my current status:

It looks like the code path I need to modify is in drivers/scsi/sd.c:rw_intr(). It looks to me that this function is called when the HBA completes an SRB and it decides if it was an error or not, and completes it correctly. I think I need to check for the NOT_READY sense status here, and if it is found, try to spin up the disk.

Now for my questions:

1) In the old patch, if the spin up failed, it calls end_scsi_request, and then requeue_sd_request. I'm not sure why it tries to requeue a failed request, but the it seems that neither of these functions exist in the 2.4 kernel. What should I use instead?

2) If the spin up worked, the old code called requeue_sd_request, I assume to send down the original read/write request to the disk now that it is on. Once again, what should I use instead of requeue_sd_request to do this? There is a comment still in the 2.4 code describing this function, but the function itself is not there.

3) The old code called scsi_do_cmd to send down a START_STOP SRB to the drive when it decides it should spin the drive back up. This function is also no longer there, so what should I use to send down the START_STOP SRB?

P.S. I'd like to use a user mode daemon to detect disk idle, and issue the existing ioctl code to spin the disk down, and rely on the kernel to spin it back up as needed. Isn't there somewhere in /proc that keeps IO counters on the disk I can monitor? Also, is there a way I could ask the kernel to not flush dirty pages to disk unless it gets a whole lot of them so the disk won't be spun up all the time just to write a few KB?

Signature · 1 line
--> Phill Susi
#1 lore raw
Quoted 2 lines · Phillip Susi

I'm trying to get my 2.4.9 system to spin down my scsi disk(s) when idle. Aparently, this is supported on IDE disks, but not SCSI. I found an old

AFAIK, the spinning down of IDE disks is done by the disks themselves rather than by the kernel. The software support consists of a method to tell the disk controller what idle period to wait before spinning down.

I don't know whether SCSI disks have a similar feature. But if they did it would be easier to make use of that than to implemement a software timer...

Signature · 4 lines
Alistair Riddell - BOFH
IT Manager, George Watson's College, Edinburgh
Tel: +44 131 447 7931 Ext 176       Fax: +44 131 452 8594
Microsoft - because god hates us
#2 lore raw
Quoted 1 line
Quoted 1 line

I'm trying to get my 2.4.9 system to spin down my scsi disk(s) when idle.

remember: normal desktop drives have an expected life of only O(50k) spin up/down cycles. that's twice an hour for a three year warranty...

regards, mark hahn.

#3 lore raw
In reply to Alistair Riddell
Quoted 6 lines · Mark Hahn
Quoted 1 line
Quoted 1 line

I'm trying to get my 2.4.9 system to spin down my scsi disk(s) when idle.

remember: normal desktop drives have an expected life of only O(50k) spin up/down cycles. that's twice an hour for a three year warranty...

regards, mark hahn.

Noflushd can be useful in this case, though it needs a patch to include/linux/kernel_stat.h in order to work with more than one IDE disk. More information is at <http://noflushd.sourceforge.net>

Granted, heavy-use servers probably do not want to spin down so much, though light-use servers could, with an high idle timeout.

Signature · 8 lines
Ferret

I will be switching my email addresses from @ferret.dyndns.org to
@mail.aom.geek on or after September 1, 2001, but not until after
Debian's servers include support. 'geek' is an OpenNIC TLD. See
http://www.opennic.unrated.net for details about adding OpenNIC
support to your computer, or ask your provider to add support to
their name servers.
#4 lore raw
In reply to Alistair Riddell
Quoted 3 lines · On Mon, Sep 10, 2001 at 09:33:26AM -0700, [email protected] wrote:

Noflushd can be useful in this case, though it needs a patch to include/linux/kernel_stat.h in order to work with more than one IDE disk. More information is at <http://noflushd.sourceforge.net>

Tweaking kernel_stat.h is no longer necessary if you're running recent ac. Alan merged a patch that exposes significantly more devices to /proc/stat. I haven't checked if it went into the 2.4.10 pres as well. Unfortunately, the patch also slightly changed the meaning of some of the entries so you'll need grab current noflushd-CVS to make it work on the second ide channel. Still, you might prefer that to patching the kernel. :)

Regards,

Daniel.

Signature · 3 lines
	GNU/Linux Audio Mechanics - http://www.glame.de
	      Cutting Edge Office - http://www.c10a02.de
	      GPG Key ID 89BF7E2B - http://www.keyserver.net
#5 lore raw
In reply to Phillip Susi
Quoted 6 lines · Phillip Susi

I'm trying to get my 2.4.9 system to spin down my scsi disk(s) when idle. Aparently, this is supported on IDE disks, but not SCSI. I found an old patch to add support for this to the 2.0.34 kernel, and have been trying to use it as a guide to fixing the 2.4.9 kernel. It seems that major changes have been done to the scsi layer, so I'm a little confused. Any help is appreciated. Here is my current status:

I had played around with scsi spinup a couple of months ago but then had to give away my scsi system, so the patch remained unfinished. Let me dig in the dust...

Trying to trap NOT_READY was fine, but I believe the tricky part was one should avoid to allocate a new request for the spinup command. The number of requests in the queue is limited, so an additional request issued from an incomplete request might deadlock. So you have to piggyback the spinup on the original command, catch it when it completes, and re-issue the command. Some of the error handlers do similar stuff, but clobber a few entries from the original command. I therefore added new backup fields to Scsi_Cmnd in scsi.h. The other changes were local to scsi_lib.c, IIRC.

Quoted 3 lines

P.S. I'd like to use a user mode daemon to detect disk idle, and issue the existing ioctl code to spin the disk down, and rely on the kernel to spin it back up as needed.

As already suggested elsewhere in this thread, please have a look at noflushd
(http://noflushd.sourceforge.net). It implements all the user level features you describe. The scsi code is disabled by default, however, because of the lack of spinup support in the standard kernel. The lastest scsi spinup patch shipped with noflushd applies to kernel 2.3.28. If you cook up a patch that works with recent kernels, please let me know!

Regards,

Daniel.

Signature · 3 lines
	GNU/Linux Audio Mechanics - http://www.glame.de
	      Cutting Edge Office - http://www.c10a02.de
	      GPG Key ID 89BF7E2B - http://www.keyserver.net