Skip to contentSkip to conversation

2.4.0 and QoS installation

DISCUSSION Radivoje Todorovic 4 participants 5 messages Sep 21, 2001 – Sep 22, 2001 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

I have untared SAME linux-2.4.0.tar.gz on two PCs and when I did make menuconfig in the networking section, only on one of the two machines there was a choice to use QoS and Fair Queueing.

What is the trick? Or what HW check menuconfig performed before it created the menu?
Rade

#2 lore raw
Quoted 7 lines · Radivoje Todorovic

I have untared SAME linux-2.4.0.tar.gz on two PCs and when I did make menuconfig in the networking section, only on one of the two machines there was a choice to use QoS and Fair Queueing.

What is the trick? Or what HW check menuconfig performed before it created the menu?
Rade

diff is your friend: just have a look at the differences between the two .config. Anyway, I'd bet you enabled CONFIG_EXPERIMENTAL only on one of the two.

.TM.

Signature · 5 lines
      ____/  ____/   /
     /      /       /			Marco Colombo
    ___/  ___  /   /		      Technical Manager
   /          /   /			 ESI s.r.l.
 _____/ _____/  _/		       [email protected]
#3 lore raw

Re: 2.4.10pre13aa1

In reply to a message not in the archive
Quoted 17 lines · Andrea Arcangeli

Only in 2.4.10pre13aa1: 00_unmap-dirty-pte-1

I grepped over the whole 600 pages of the latest x86 system developer manual and I couldn't find the proof that I'm wrong.

We can have pagecache pages with pte writeable and non dirty at some point.

Now what happens if the userspace task in the other cpu touches the writeable page between our "ptep_get_and_clear" and the "flush_tlb_page"? Is the resulting pte still zero and the task get into a page fault? Or as I am worried it could also just end with the pte with only the dirty bit set? Does somebody know for sure? I can imagine the cpu finding the tlb state writeable, and issuing just a locked bit test and set in the pte without caring to check if the pte is zero or not.

Quoted 3 lines

If the cpu just set the bit this patch will avoid to lose a shared mapping update. Otherwise it's a safe noop so I keep it applied until this issue is sorted out.

I've tested this on all the machines I could get my hands on, and every single CPU will take a page fault if the pte is not present on dirtying the page. If people are truely paranoid, then make it a boot time assertion.

-ben

#4 lore raw

Re: 2.4.10pre13aa1

In reply to a message not in the archive
Quoted 1 line · Benjamin LaHaise

the page. If people are truely paranoid, then make it a boot time assertion.

What do you think if I replace the mkdirty with a BUG() in case the pte gets marked dirty? Just to be sure no hardware gets it wrong.

Andrea

#5 lore raw

Re: 2.4.10pre13aa1

In reply to a message not in the archive
Quoted 5 lines · Andrea Arcangeli
Quoted 1 line · Benjamin LaHaise

the page. If people are truely paranoid, then make it a boot time assertion.

What do you think if I replace the mkdirty with a BUG() in case the pte gets marked dirty? Just to be sure no hardware gets it wrong.

Sure. At some point it should be made part of debugging-only builds. Cheers,

-ben