Skip to contentSkip to conversation

PATCH: sonypi wrongly claims ownership of ISA and ACPI bridges

PATCH Marcus Meissner 2 participants 2 messages Oct 15, 2001

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi Stelian,

Your sonypi driver claims the ownership of 2 Intel ACPI bridges and 1 ISA bridge.

All 3 are used in standard Intel chipsets, not just in Sony VAIOs.

Please do not use them, it confuses the hell out of the autoprobing and automatic PCI driver registration.

I suggest checking up if this device has PnPBIOS entries and using them, or using a different method of autoprobing.

Ciao, Marcus

Index: sonypi.c
===================================================================
RCS file: /build/mm/work/repository/linux-mm/drivers/char/sonypi.c,v retrieving revision 1.20

sonypi.c +0 -2
diff -u -r1.20 sonypi.c
@@ -689,8 +689,6 @@
 	{ }
 };
 
-MODULE_DEVICE_TABLE(pci, sonypi_id_tbl);
-
 static struct pci_driver sonypi_driver = {
 	name:		"sonypi",
 	id_table:	sonypi_id_tbl,
#1 lore raw
Quoted 10 lines · Marcus Meissner

Your sonypi driver claims the ownership of 2 Intel ACPI bridges and 1 ISA bridge.

All 3 are used in standard Intel chipsets, not just in Sony VAIOs.

Please do not use them, it confuses the hell out of the autoprobing and automatic PCI driver registration.

I suggest checking up if this device has PnPBIOS entries and using them, or using a different method of autoprobing.

Testing against is_sony_vaio_laptop should be sufficient here.

Alan, please apply the following patch (instead of Marcus' one). It changes the initialisation sequence (first the ISA bridge for the older hardware, then it supposes newer hardware), and doesn't registers itself in the kernel pci device table.

A little documentation update is also included.

Thanks,

Stelian.

Documentation/sonypi.txt +4 -2
diff -uNr --exclude-from=dontdiff linux-2.4.12-ac2.orig/Documentation/sonypi.txt linux-2.4.12-ac2/Documentation/sonypi.txt
@@ -55,7 +55,9 @@
 			in order to let the driver access to the camera
 
 	fnkeyinit:	on some Vaios (C1VE, C1VR etc), the Fn key events don't
-			get enabled unless you set this parameter to 1
+			get enabled unless you set this parameter to 1.
+			Do not use this option unless it's actually necessary,
+			some Vaio models don't deal well with this option.
 
 	verbose:	print unknown events from the sonypi device
 
@@ -71,7 +73,7 @@
 lines in your /etc/modules.conf file:
 
 	alias char-major-10-250 sonypi
-	options sonypi minor=250 fnkeyinit=1
+	options sonypi minor=250
 
 This supposes the use of minor 250 for the sonypi device:
 
drivers/char/sonypi.c +17 -37

95 lines not on this page · raw message

drivers/char/sonypi.h +1 -1
diff -uNr --exclude-from=dontdiff linux-2.4.12-ac2.orig/drivers/char/sonypi.h linux-2.4.12-ac2/drivers/char/sonypi.h
@@ -35,7 +35,7 @@
 #ifdef __KERNEL__
 
 #define SONYPI_DRIVER_MAJORVERSION	1
-#define SONYPI_DRIVER_MINORVERSION	6
+#define SONYPI_DRIVER_MINORVERSION	7
 
 #include <linux/types.h>
 #include <linux/pci.h>
Signature · 4 lines
Stelian Pop <[email protected]>
|---------------- Free Software Engineer -----------------|
| Alcôve - http://www.alcove.com - Tel: +33 1 49 22 68 00 |
|------------- Alcôve, liberating software ---------------|