2.4.13pre5aa1
Quoted 4 lines · In article <1003470485.913.13.camel@phantasy> Robert Love wrote:
Quoted 2 lines · Andrea Arcangeli
Only in 2.4.13pre3aa1: 00_files_struct_rcu-2.4.10-04-1 Only in 2.4.13pre5aa1: 00_files_struct_rcu-2.4.10-04-2
Quoted 8 lines
I want to point out to preempt-kernel users that RCU is not preempt-safe. The implicit locking assumed from per-CPU data structures is defeated by preemptibility.
(Actually, FWIW, I think I can think of ways to make RCU preemptible but it would involve changing the write-side quiescent code for the case where the pointers were carried over the task switches. Probably not worth it.)
I agree. Differentiating between context switches that do or don't carry over pointers requires several additional complications that are probably not worth it at this moment.
Quoted 4 lines
This is not to say RCU is worthless with a preemptible kernel, but that we need to make it safe (and then make sure it is still a performance advantage, but I don't think this would add much overhead). Note this is clean, simply wrapping the read code in non-preemption statements.
Yes. The lookup of data protected by RCU should be done with preemption disabled.
preempt_disable();
traverse linked list or such things protected by RCU. preempt_enable();
Thanks
Dipankar
Signature · 2 lines
Dipankar Sarma <[email protected]> http://lse.sourceforge.net Linux Technology Center, IBM Software Lab, Bangalore, India.