Skip to contentSkip to conversation

Intel 845 support for agpgart

PATCH In review Shyouzou Sugitani 2 participants 4 messages Oct 30, 2001 – Oct 31, 2001

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Intel 845 support for agpgart

Hi,

this patch for 2.4.14-pre5 adds support for the Intel i845 chipset to the agpgart module.
It seems to work fine on my ASUS P4B with Matrox G450.

--
Regards,
Shyouzou Sugitani <[email protected]>

include/linux/agp_backend.h renamed from include/linux/agp_backend.h.dist +1 -0
@@ -48,6 +48,7 @@
 	INTEL_I815,
 	INTEL_I830_M,
 	INTEL_I840,
+	INTEL_I845,
 	INTEL_I850,
 	VIA_GENERIC,
 	VIA_VP3,
drivers/char/agp/agp.h renamed from drivers/char/agp/agp.h.dist +7 -0
@@ -173,6 +173,9 @@
 #ifndef PCI_DEVICE_ID_INTEL_840_0
 #define PCI_DEVICE_ID_INTEL_840_0		0x1a21
 #endif
+#ifndef PCI_DEVICE_ID_INTEL_845_0
+#define PCI_DEVICE_ID_INTEL_845_0     0x1a30
+#endif
 #ifndef PCI_DEVICE_ID_INTEL_850_0
 #define PCI_DEVICE_ID_INTEL_850_0     0x2530
 #endif
@@ -254,6 +257,10 @@
 /* intel i840 registers */
 #define INTEL_I840_MCHCFG   0x50
 #define INTEL_I840_ERRSTS	0xc8
+
+/* intel i845 registers */
+#define INTEL_I845_MCHCFG   0x51
+#define INTEL_I845_ERRSTS   0xc8
 
 /* intel i850 registers */
 #define INTEL_I850_MCHCFG   0x50
drivers/char/agp/agpgart_be.c renamed from drivers/char/agp/agpgart_be.c.dist +72 -1

97 lines not on this page · raw message

drivers/char/Config.in renamed from drivers/char/Config.in.dist +1 -1
@@ -206,7 +206,7 @@
 
 dep_tristate '/dev/agpgart (AGP Support)' CONFIG_AGP $CONFIG_DRM_AGP
 if [ "$CONFIG_AGP" != "n" ]; then
-   bool '  Intel 440LX/BX/GX and I815/I830M/I840/I850 support' CONFIG_AGP_INTEL
+   bool '  Intel 440LX/BX/GX and I815/I830M/I840/I845/I850 support' CONFIG_AGP_INTEL
    bool '  Intel I810/I815/I830M (on-board) support' CONFIG_AGP_I810
    bool '  VIA chipset support' CONFIG_AGP_VIA
    bool '  AMD Irongate, 761, and 762 support' CONFIG_AGP_AMD
Documentation/Configure.help renamed from Documentation/Configure.help.dist +2 -2
@@ -2629,10 +2629,10 @@
   module, say M here and read Documentation/modules.txt. The module
   will be called agpgart.o.
 
-Intel 440LX/BX/GX/815/830M/840/850 support
+Intel 440LX/BX/GX/815/830M/840/845/850 support
 CONFIG_AGP_INTEL
   This option gives you AGP support for the GLX component of the
-  XFree86 4.x on Intel 440LX/BX/GX, 815, 830M, 840 and 850 chipsets.
+  XFree86 4.x on Intel 440LX/BX/GX, 815, 830M, 840, 845 and 850 chipsets.
 
   For the moment, you should probably say N, unless you want to test
   the GLX component for XFree86 3.3.6, which can be downloaded from
#1 lore raw

At Wed, 31 Oct 2001 07:49:18 +0900,

Quoted 5 lines · Shyouzou Sugitani

Hi,

this patch for 2.4.14-pre5 adds support for the Intel i845 chipset to the agpgart module.
It seems to work fine on my ASUS P4B with Matrox G450.

Aha, this patch already sent by me some hours before and its function is totally same :-)

Alan, please apply our patch.

Thanks,
-- gotom

#2 lore raw

At Wed, 31 Oct 2001 08:54:06 +0900

Quoted 2 lines · GOTO Masanori

Aha, this patch already sent by me some hours before and its function is totally same :-)

OK, I read your patch which appeared in Linux-Kernel Archive and found that its function is not totally same.

The MCHCFG register of i845 is only 8bits.

--
Regards,
Shyouzou Sugitani <[email protected]>

#3 lore raw

At Wed, 31 Oct 2001 11:30:03 +0900,

Quoted 10 lines · Shyouzou Sugitani

At Wed, 31 Oct 2001 08:54:06 +0900

Quoted 2 lines · GOTO Masanori

Aha, this patch already sent by me some hours before and its function is totally same :-)

OK, I read your patch which appeared in Linux-Kernel Archive and found that its function is not totally same.

The MCHCFG register of i845 is only 8bits.

Ahh, you're right, it's my mistake...
BTW, I've noticed trivial issue that INTEL_I845_MCHCFG is not appropriate name. Changing INTEL_I845_MCHCFG -> INTEL_I845_AGPM or so is more appropriate because MCHCFG indicates other register 0xC6.
The patch for -ac5 with yours and merging me drm is at:

	http://www2.fe.dis.titech.ac.jp/~gotom/tmp/linux/patch.2.4.13-ac5.agp

Regards,
-- gotom