Skip to contentSkip to conversation

elvtune fails with DAC960 and devfs on 2.4.14

DISCUSSION Brian Ristuccia 3 participants 3 messages Nov 13, 2001 – Nov 14, 2001

lore
Share & tools
lore
#0 lore raw

I can't seem to adjust the elevator parameters for this block device, but can't:

# elvtune /dev/rd/disc0/disc
ioctl get: Invalid argument

Tried unsucessfully with elvtune from Debian's elvtune package 2.11l-3 and also 2.11m from kernel.org.

Any hints?

Signature · 2 lines
Brian Ristuccia
[email protected]
#1 lore raw
Quoted 4 lines · Brian Ristuccia

I can't seem to adjust the elevator parameters for this block device, but can't:

# elvtune /dev/rd/disc0/disc
ioctl get: Invalid argument

DAC960.c doesn't know about BLKELVSET / BLKELVGET, and control is only passed down to the generic ioctl in the case of BLKBSZSET, and doesn't have a default: entry in the switch statement of DAC960_IOCTL()

I've not seen one of these devices, so I'm not sure if this makes sense or not, but passing on requests to the lower level should be a simple..

	default:
		return( blk_ioctl(Inode->i_rdev, Request, Argument));

Addition.

There may be other reasons this driver doesn't provide the elevator ioctls though.

regards,

Dave.

Signature · 2 lines
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
#2 lore raw
In reply to Brian Ristuccia
Quoted 12 lines · Dave Jones
Quoted 4 lines · Brian Ristuccia

I can't seem to adjust the elevator parameters for this block device, but can't:

# elvtune /dev/rd/disc0/disc
ioctl get: Invalid argument

DAC960.c doesn't know about BLKELVSET / BLKELVGET, and control is only passed down to the generic ioctl in the case of BLKBSZSET, and doesn't have a default: entry in the switch statement of DAC960_IOCTL()

Quoted 8 lines

I've not seen one of these devices, so I'm not sure if this makes sense or not, but passing on requests to the lower level should be a simple..

	default:
		return( blk_ioctl(Inode->i_rdev, Request, Argument));

Addition.

Or just add it to the BLKBSZGET etc string that pass it on to blk_ioctl anyways.

Quoted 2 lines

There may be other reasons this driver doesn't provide the elevator ioctls though.

None, it was simply never added.

Signature · 1 line
Jens Axboe