Skip to contentSkip to conversation

Etiquette of getting a driver into the kernel

DISCUSSION John P. Looney 2 participants 2 messages Nov 23, 2001

lore
Share & tools
lore
#0 lore raw

I've a Phison "usb multiple card reader". Nice little device, though I
think the driver isn't the best (block size of 1k when reading & writing gets 80k/sec, block size of 32k gets 850k/sec).

The device came with a driver for linux on a floppy, as a patch against
2.4.2. It needed a little beating to get it to compile, and it caused not-a-few kernel panics. Some kind soul on the net mailed me a newer version, which does work a lot more reliably. The email address given for the original author (in the source) doesn't seem to answer requests like "is there a newer version of this driver", or "Is this driver GPL'd ?".

Basically, I've a patch for it against 2.4.15, and I'm wondering how I
should go about getting it into the kernel, so others can debug it for me :)

John

Signature · 4 lines
_______________________________________
John Looney             Chief Scientist
a n t e f a c t o     t: +353 1 8586004
www.antefacto.com     f: +353 1 8586014
#1 lore raw
Quoted 2 lines · John P. Looney

Basically, I've a patch for it against 2.4.15, and I'm wondering how I
should go about getting it into the kernel, so others can debug it for me :)

It is both a social and a technical ritual, like a raindance. First you start by removing the obviously ugly parts of your patch, and then continue to polish it 'till it shines. Then you send a loving message to the relevant subsystem maintainer, asking for his/her advice.

'How would you like to see this driver' is the question to ask. Mostly you will then hear that you did everything wrong, that your tabstyle sucks, that this would not survive 10 seconds on my 64G quad xeon and that it would be far easier to modify driver x-y-z to support your hardware too, where x-y-z is not in the least related to your problem.

This is the time to persist. What you are seeing is part of a necessary ritual. Challenge the subsystem maintainer and show your respect by following the saner parts of his message. Clean up your coding style, use kernel infrastructure as suggested, heed arcane hints about locks that need or to need to be held.

Resubmit and argue. Lobby. Document. Resubmit and argue. Keep sending patches.

And in due time if everything is right, the subsystem maintainer will accept your patch and feed it to Marcelo or Linus.

Some maintainers are more stubborn then others, by the way. But always keep in mind that code is king and that it may take a while to bang it into shape.

Regards,

bert hubert

Signature · 4 lines
http://www.PowerDNS.com          Versatile DNS Software & Services
Trilab                                 The Technology People
Netherlabs BV / Rent-a-Nerd.nl           - Nerd Available -
'SYN! .. SYN|ACK! .. ACK!' - the mating call of the internet