Linux 2.4.17-pre1
Quoted 4 lines · Marcelo Tosatti
pre1:
- Added missing
MODULE_LICENSE("GPL")in some (Andreas Krennmair)
modules
Below is yet another one, for ide-tape.c; please apply.
The files in fs/nls/ that have license tags (nls_iso8859-1.c lacks one), use "BSD without advertising clause", which causes the kernel to be tainted. Shouldn't fs/nls/*.c use "Dual BSD/GPL" or "GPL" instead?
/Mikael
drivers/ide/ide-tape.c renamed from drivers/ide/ide-tape.c.~1~ +1 -0
@@ -6182,6 +6182,7 @@ };MODULE_DESCRIPTION ("ATAPI Streaming TAPE Driver" ); +MODULE_LICENSE ("GPL" ); static void __exit idetape_exit (void) {
Quoted 2 lines
use "BSD without advertising clause", which causes the kernel to be tainted. Shouldn't
fs/nls/*.cuse "Dual BSD/GPL" or "GPL" instead?
Dual BSD/GPL is the correct one. Not a big issue. Since the GPL allows stuff to be freer than GPL but still GPL its arguably correct too I suspect
Quoted 6 lines · Alan Cox
Quoted 2 lines
use "BSD without advertising clause", which causes the kernel to be tainted. Shouldn't
fs/nls/*.cuse "Dual BSD/GPL" or "GPL" instead?Dual BSD/GPL is the correct one. Not a big issue. Since the GPL allows stuff to be freer than GPL but still GPL its arguably correct too I suspect
I was waiting for confirmation about the license status...without getting into what license is correct and legal, the current MODULE_LICENSE value taints the kernel. The attached patch switches to Dual BSD/GPL.
Marcelo, please apply.
Robert Love
fs/nls/nls_cp1251.c +1 -1
@@ -315,4 +315,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp1255.c +1 -1
@@ -396,4 +396,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp437.c +1 -1
@@ -401,4 +401,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp737.c +1 -1
@@ -364,4 +364,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp775.c +1 -1
@@ -333,4 +333,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp850.c +1 -1
@@ -329,4 +329,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp852.c +1 -1
@@ -351,4 +351,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp855.c +1 -1
@@ -313,4 +313,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp857.c +1 -1
@@ -315,4 +315,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp860.c +1 -1
@@ -378,4 +378,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp861.c +1 -1
@@ -401,4 +401,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp862.c +1 -1
@@ -435,4 +435,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp863.c +1 -1
@@ -395,4 +395,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp864.c +1 -1
@@ -421,4 +421,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp865.c +1 -1
@@ -401,4 +401,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp866.c +1 -1
@@ -319,4 +319,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp869.c +1 -1
@@ -329,4 +329,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
fs/nls/nls_cp874.c +1 -1
@@ -287,4 +287,4 @@* c-continued-brace-offset: 0 * End: */ -MODULE_LICENSE ("BSD without advertising clause" ); +MODULE_LICENSE ("Dual BSD/GPL" );
On Wed, 28, Nov, 2001 at 06:48:13PM -0500, Robert Love spoke thus..
Quoted 10 lines · Alan Cox
Quoted 8 lines
Quoted 3 lines
use "BSD without advertising clause", which causes the kernel to be
tainted. Shouldn'tfs/nls/*.cuse "Dual BSD/GPL" or "GPL" instead?Dual BSD/GPL is the correct one. Not a big issue. Since the GPL allows
stuff to be freer than GPL but still GPL its arguably correct too I suspect
Quoted 5 lines
I was waiting for confirmation about the license status...without getting into what license is correct and legal, the current
MODULE_LICENSEvalue taints the kernel. The attached patch switches to
Dual BSD/GPL.
Do you know what the legal status of the rest of the *.c files in fs/nls is? There are still quite a few which have no MODULE_LICENSE tag at all which causes the kernel to be tainted (IMO) incorrectly.
Mark
Signature · 2 lines
Mark Hymers BLFS Editor [email protected]
Quoted 3 lines · Mark Hymers
Do you know what the legal status of the rest of the *.c files in fs/nls is? There are still quite a few which have no
MODULE_LICENSEtag at all which causes the kernel to be tainted (IMO) incorrectly.
I believe all the fs/nls files are GPL or Dual GPL/something else.
Robert Love