Skip to contentSkip to conversation

PATCH: linux-2.5.1-pre7/drivers/block/xd.c compilation fix (version 2)

DISCUSSION Adam J. Richter 2 participants 2 messages Dec 9, 2001 Block layer

lore
Share & tools
lore
#0 lore raw
Quoted 5 lines
Quoted 2 lines

Linus, if nobody says otherwise, I recommend that you apply
this patch.

Well, I already applied your previous one, in fact, and it's in the just-uploaded pre8 kernel.

Thanks!

Quoted 1 line

Mind verifying that and sending the incremental update?

No problem. I have attached the one line addition below.

Quoted 2 lines

Btw, do you actually _have_ a machine that uses the xd driver, or was this patch done just out of some perverse joy in theoretical retrocomputing?

Years ago, I submitted a patch to allow configuration of
the kernel with "./configure", which would configure every driver as a module, aside from compiling in the initial ramdisk and the initial ramdisk's filesystem. I haven't configured a kernel for years; the boot scripts and hot plugging software do that. The same binary build of the kernel can run on all of my x86 hardware.

That is why I know that 92 files failed to compile on x86 in
2.5.1-pre7, and largely why I care about fixing xd.c.

Anyhow, thanks for asking. By the way, if you have any interest
in integrating my "./configure" functionality now, I would be happy to clean it up and resubmit it. (It is mostly a patch to scripts/Configure.)

Adam J. Richter     __     ______________   4880 Stevens Creek Blvd, Suite 104
[email protected]     \ /                  San Jose, California 95129-1034
+1 408 261-6630         | g g d r a s i l   United States of America

fax +1 408 261-6631 "Free Software For The Rest Of Us."

drivers/block/xd.c +1 -0
@@ -287,6 +287,7 @@
 		INIT_REQUEST;	/* do some checking on the request structure */
 
 		if (CURRENT_DEV < xd_drives
+		    && (CURRENT->flags & REQ_CMD)
 		    && CURRENT->sector + CURRENT->nr_sectors
 		         <= xd_struct[MINOR(CURRENT->rq_dev)].nr_sects) {
 			block = CURRENT->sector;
#1 lore raw
Quoted 3 lines · Adam J. Richter

Anyhow, thanks for asking. By the way, if you have any interest
in integrating my "./configure" functionality now, I would be happy to clean it up and resubmit it. (It is mostly a patch to scripts/Configure.)

Already in kbuild 2.5, it supports make allyes, allno, allmod, random.