Skip to contentSkip to conversation

remove redundant lock_kernel

PATCH New David C. Hansen 1 participant 1 message Dec 17, 2001 Proc filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove redundant lock_kernel

In fs/proc/proc_misc.c:locks_read_proc(), the BKL is grabbed while calling get_locks_status(). But, this function holds the BKL for all of its list operations already. I know that the BKL can be held recursively, but I don't see any need for this extra lock. Patch against 2.5.1 attached.

fs/proc/proc_misc.c +0 -2
@@ -409,9 +409,7 @@
 				 int count, int *eof, void *data)
 {
 	int len;
-	lock_kernel();
 	len = get_locks_status(page, start, off, count);
-	unlock_kernel();
 	if (len < count) *eof = 1;
 	return len;
 }