Skip to contentSkip to conversation

Slight optimizations to entry.S patch

PATCH Alex 4 participants 4 messages Dec 20, 2001 – Dec 21, 2001

lore
Share & tools
lore

Alex

author
#0 lore raw

Hi,
I was familiarizing (or trying to) myself with the i386 architecture code, and saw a few possible optimizations. I think they can save a few cycles (not that many). Can someone comment? Are the changes worthwhile? -Alex K.

entry.S renamed from entry.S.orig +5 -5
@@ -91,9 +91,9 @@
 	pushl %edi; \
 	pushl %esi; \
 	pushl %edx; \
+	movl $(__KERNEL_DS),%edx; \
 	pushl %ecx; \
 	pushl %ebx; \
-	movl $(__KERNEL_DS),%edx; \
 	movl %edx,%ds; \
 	movl %edx,%es;
 
@@ -141,13 +141,13 @@
 	movl EFLAGS(%esp),%ecx	# and this is cs..
 	movl %eax,EFLAGS(%esp)	#
 	movl %edx,EIP(%esp)	# Now we move them to their "normal" places
-	movl %ecx,CS(%esp)	#
 	movl %esp,%ebx
+	movl %ecx,CS(%esp)	#
 	pushl %ebx
 	andl $-8192,%ebx	# GET_CURRENT
 	movl exec_domain(%ebx),%edx	# Get the execution domain
-	movl 4(%edx),%edx	# Get the lcall7 handler for the domain
 	pushl $0x7
+	movl 4(%edx),%edx	# Get the lcall7 handler for the domain
 	call *%edx
 	addl $4, %esp
 	popl %eax
@@ -162,13 +162,13 @@
 	movl EFLAGS(%esp),%ecx	# and this is cs..
 	movl %eax,EFLAGS(%esp)	#
 	movl %edx,EIP(%esp)	# Now we move them to their "normal" places
-	movl %ecx,CS(%esp)	#
 	movl %esp,%ebx
+	movl %ecx,CS(%esp)	#
 	pushl %ebx
 	andl $-8192,%ebx	# GET_CURRENT
 	movl exec_domain(%ebx),%edx	# Get the execution domain
-	movl 4(%edx),%edx	# Get the lcall7 handler for the domain
 	pushl $0x27
+	movl 4(%edx),%edx	# Get the lcall7 handler for the domain
 	call *%edx
 	addl $4, %esp
 	popl %eax
#1 lore raw
Quoted 4 lines · Alex

Hi,
I was familiarizing (or trying to) myself with the i386 architecture code, and saw a few possible optimizations. I think they can save a few cycles (not that many). Can someone comment? Are the changes worthwhile?

The first page of your x86 book starts talking about read-after-write pipeline stall ? Damn what a book :)

- Davide

#2 lore raw
Quoted 2 lines · Davide Libenzi

The first page of your x86 book starts talking about read-after-write pipeline stall ? Damn what a book :)

Haha, he actually did help w.r.t to that ... good patch. Sure, its micro optimizations but not in any bad sense. If it works, submit it.

I'll try it out on my next reboot.

Robert Love

#3 lore raw
In reply to Alex
Quoted 3 lines

I was familiarizing (or trying to) myself with the i386 architecture code, and saw a few possible optimizations. I think they can save a few cycles (not that many). Can someone comment? Are the changes worthwhile?

Measure them and see - look at the rdtsc instruction, run a million iterations of all the various variants and see what you find