Skip to contentSkip to conversation

Hello. Patch time (drivers/block/loop.c)

PATCH Eric Windisch 2 participants 4 messages Dec 22, 2001 Block layer

lore
Share & tools
lore
#0 lore raw

Hello. I would like to formally introduce myself to this list, as this is my first post. Of course, I would not come to the table empty handed.. I bring to you a patch ;)

I was digging around the loopback block device driver and it wasn't long before I realized that it assumes you are writing if you are not reading.. which I assume could be hazardous if there is an overflow, bad memory, or someone modifies some other code without knowledge :)

Patch attached.

I may be looking at this and the multi-device drivers in the near future as I have a need for support for partitions on these devices; I think it would be really neat if the software-raid could eventually become compatable with hardware raid.. although much slower, it may be a nice thing to have for testing purposes or a last resort for those who fry their hardware raid-controllers ;)

--
Eric Windisch
http://bwbohh.net

drivers/block/loop.c +6 -2
@@ -90,8 +90,10 @@
 	if (raw_buf != loop_buf) {
 		if (cmd == READ)
 			memcpy(loop_buf, raw_buf, size);
-		else
+		else if (cmd == WRITE) 
 			memcpy(raw_buf, loop_buf, size);
+		else
+			printk(KERN_ERR "loop: Illegal command, %d", cmd);
 	}
 
 	return 0;
@@ -106,9 +108,11 @@
 	if (cmd == READ) {
 		in = raw_buf;
 		out = loop_buf;
-	} else {
+	} else if (cmd == WRITE) {
 		in = loop_buf;
 		out = raw_buf;
+	} else {
+		printk(KERN_ERR "loop: Illegal command, %d", cmd);
 	}
 
 	key = lo->lo_encrypt_key;
#1 lore raw
Quoted 2 lines · Eric Windisch

I may be looking at this and the multi-device drivers in the near future as I have a need for support for partitions on these devices;

Contact Neil Brown, as this is already done. That is a "feature" of Linux - most things you want to do have already been done by someone else.

Quoted 2 lines

I think it would be really neat if the software-raid could eventually become compatable with hardware raid.. although much slower

In many cases, software raid is as fast or faster than hardware raid. What do you mean by "compatible"?

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/

#2 lore raw
In reply to Eric Windisch
Quoted 3 lines · Andreas Dilger

Contact Neil Brown, as this is already done. That is a "feature" of Linux - most things you want to do have already been done by someone else.

I will look into that, do you have a url or email address (otherwise I'll use google or RTFM)?

Quoted 6 lines
Quoted 3 lines

I think it would be really neat if the software-raid could eventually become compatable with hardware raid.. although much slower

In many cases, software raid is as fast or faster than hardware raid. What do you mean by "compatible"?

Well, it would be nice if I could easily replace a raid controller with software raid.. if this could be possible, I assume it could be.

--
Eric Windisch
http://bwbohh.net

#3 lore raw
In reply to Eric Windisch
Quoted 7 lines · Eric Windisch
Quoted 3 lines · Andreas Dilger

Contact Neil Brown, as this is already done. That is a "feature" of Linux - most things you want to do have already been done by someone else.

I will look into that, do you have a url or email address (otherwise I'll use google or RTFM)?

Actually, I went ahead and RTFM.. I found the patch, thanks! :)

--
Eric Windisch
http://bwbohh.net