Skip to contentSkip to conversation

Patch for eepro100 to support more cards

DISCUSSION Hanno Böck 3 participants 4 messages Feb 1, 2002 – Feb 7, 2002 Network drivers

lore
Share & tools
lore
#0 lore raw

This patch adds support for the
Intel Pro/100 VE
Network card to the eepro100.c

This card is installed in my notebook (Sony Vaio PCG-GR114MK). Seems to work fine.

Patch is for Kernel 2.4.17

--- linux/drivers/net/eepro100.c        Fri Dec 21 18:41:54 2001 +++ linux-2.4.17-patch/drivers/net/eepro100.c   Thu Jan 31 15:51:50 2002 @@ -168,6 +168,9 @@
 #ifndef PCI_DEVICE_ID_INTEL_ID1030
 #define PCI_DEVICE_ID_INTEL_ID1030 0x1030
 #endif
+#ifndef PCI_DEVICE_ID_INTEL_ID1031              // Support for Intel Pro/100 VE added by Hanno Boeck <[email protected]>
+#define PCI_DEVICE_ID_INTEL_ID1031 0x1031
+#endif

 static int speedo_debug = 1;
@@ -2270,6 +2273,8 @@
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1029, PCI_ANY_ID, PCI_ANY_ID, },
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1030,
+               PCI_ANY_ID, PCI_ANY_ID, },
+       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1031,         // Support for
Intel Pro/100 VE added by Hanno Boeck <[email protected]>
                PCI_ANY_ID, PCI_ANY_ID, },
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_7, PCI_ANY_ID, PCI_ANY_ID, },

#1 lore raw
Quoted 6 lines · Hanno Böck

This patch adds support for the
Intel Pro/100 VE
Network card to the eepro100.c

This card is installed in my notebook (Sony Vaio PCG-GR114MK). Seems to work fine.

Nice!

[snip]

Quoted 2 lines

+#ifndef PCI_DEVICE_ID_INTEL_ID1031 // Support for Intel Pro/100
VE added by Hanno Boeck <[email protected]>

[snip]

PLEASE put this kind of comments in the changelog or similarly fitting place instead of in the code. If everyone had their e-mail address in a comment after every line they added, would be bloated beyond proportions (some argue that it already is, but let's ignore that for now...)

Regards: David Weinehall
_ _
// David Weinehall <[email protected]> /> Northern lights wander \\

//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\>  http://www.acc.umu.se/~tao/    </   Full colour fire           </
#2 lore raw
In reply to Hanno Böck

Because of some complains and as pre8 is out now, I made it again for the 2.4.18pre8-kernel. I hope it is okay now.

I put up a site for the patch: http://www.int21.de/eepro100/

The Patch adds definitions for the Intel Pro/100 VE-card to the eepro100-driver.

drivers/net/eepro100.c +5 -0
@@ -168,6 +168,9 @@
 #ifndef PCI_DEVICE_ID_INTEL_ID1030
 #define PCI_DEVICE_ID_INTEL_ID1030 0x1030
 #endif
+#ifndef PCI_DEVICE_ID_INTEL_ID1031          /* support for Intel Pro/100 VE */
+#define PCI_DEVICE_ID_INTEL_ID1031 0x1031
+#endif
 
 
 static int speedo_debug = 1;
@@ -2270,6 +2273,8 @@
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1029,
 		PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1030,
+		PCI_ANY_ID, PCI_ANY_ID, },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1031,     /* support for Intel Pro/100 VE */
 		PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_7,
 		PCI_ANY_ID, PCI_ANY_ID, },
#3 lore raw
In reply to Hanno Böck

Hanno,

Patches that I had previously sent to add support for other cards were not accepted when I had it done like this. The fix was to ad an entry for the PCI ID into include/linux/pci_ids.h instead of adding defines into eepro100.c. You might try changing that and resubmitting, it is a cleaner way to do it anyway.

Josh

Quoted 34 lines · Hanno Böck

Because of some complains and as pre8 is out now, I made it again for the 2.4.18pre8-kernel. I hope it is okay now.

I put up a site for the patch: http://www.int21.de/eepro100/

The Patch adds definitions for the Intel Pro/100 VE-card to the eepro100-driver.

drivers/net/eepro100.c +1 -0
@@ -168,6 +168,9 @@
 #ifndef PCI_DEVICE_ID_INTEL_ID1030
 #define PCI_DEVICE_ID_INTEL_ID1030 0x1030
 #endif
+#ifndef PCI_DEVICE_ID_INTEL_ID1031          /* support for Intel Pro/100

VE */ +#define PCI_DEVICE_ID_INTEL_ID1031 0x1031

drivers/net/eepro100.c +3 -1
+#endif
 
 
 static int speedo_debug = 1;
@@ -2270,6 +2273,8 @@
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1029,
 		PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1030,
+		PCI_ANY_ID, PCI_ANY_ID, },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ID1031,     /* support for
 Intel Pro/100 VE */ PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_7,
 		PCI_ANY_ID, PCI_ANY_ID, },
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/