Skip to contentSkip to conversation

Tiny IDE cleanup

PATCH Pavel Machek 3 participants 3 messages Feb 19, 2002 – Feb 20, 2002

lore
Share & tools
lore
#0 lore raw

Hi!

What about this tiny cleanup? Its against 2.4., but applicable to 2.5, too.

Pavel

include/linux/ide.h +0 -4
@@ -697,11 +698,9 @@
  * structure directly (the allocation/layout may change!).
  *
  */
-#ifndef _IDE_C
 extern	ide_hwif_t	ide_hwifs[];		/* master data repository */
 extern	ide_module_t	*ide_modules;
 extern	ide_module_t	*ide_probe;
-#endif
 extern int noautodma;
 
 /*
@@ -900,10 +899,8 @@
 void do_ide_request (request_queue_t * q);
 void ide_init_subdrivers (void);
 
-#ifndef _IDE_C
 extern struct block_device_operations ide_fops[];
 extern ide_proc_entry_t generic_subdriver_entries[];
-#endif
 
 #ifdef _IDE_C
 #ifdef CONFIG_BLK_DEV_IDE
Signature · 2 lines
(about SSSCA) "I don't say this lightly.  However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa
#1 lore raw
Quoted 5 lines · Pavel Machek

Hi!

What about this tiny cleanup? Its against 2.4., but applicable to 2.5, too.

That's file.

If you dare to have a look at the LOCAL_END_REQUEST macro as well? It's only used by IDE and NBD code.
I think that from IDE it can be just deleted. But I didn't look at NBD.

#2 lore raw
In reply to Pavel Machek
Quoted 7 lines · Martin Dalecki
Quoted 5 lines · Pavel Machek

Hi!

What about this tiny cleanup? Its against 2.4., but applicable to 2.5, too.

Quoted 6 lines

That's file.

If you dare to have a look at the LOCAL_END_REQUEST macro as well? It's only used by IDE and NBD code.
I think that from IDE it can be just deleted. But I didn't look at NBD.

LOCAL_END_REQUEST is safe to kill, please go ahead.

Signature · 1 line
Jens Axboe