Skip to contentSkip to conversation

Linux 2.4.18 - Full tarball is OK

DISCUSSION Chris Funderburg 8 participants 10 messages Feb 25, 2002

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

FYI - The full tarball already has the missing patch...

So, I think, it's only patch-2.4.18 that has the problem...

#1 lore raw
Quoted 2 lines

FYI - The full tarball already has the missing patch... So, I think, it's only patch-2.4.18 that has the problem...

Argh thats the worst possible case. That means you can't do a single correct 2.4.18- patch

If so Marcelo can you put up 2.4.18-fixed patch and a borked-fixed diff ?

#2 lore raw
Quoted 1 line · Alan Cox

If so Marcelo can you put up 2.4.18-fixed patch and a borked-fixed diff ?

That would break hpa's incremental diff patches.

If somebody needs 2.4.18 + fix, they can just run 2.4.18-rc4.

regards,

Rik

Signature · 4 lines
"Linux holds advantages over the single-vendor commercial OS"
    -- Microsoft's "Competing with Linux" document

http://www.surriel.com/		http://distro.conectiva.com/
#3 lore raw
Quoted 4 lines
Quoted 1 line

If so Marcelo can you put up 2.4.18-fixed patch and a borked-fixed diff ?

That would break hpa's incremental diff patches.
If somebody needs 2.4.18 + fix, they can just run 2.4.18-rc4.

That isnt the problem. Is 2.4.19-pre1 a patch versus the 2.4.18 tarball or the 2.4.18 patch ? Continue ad infinitum through every 2.4 release, add hundreds of confused emails about them to the kernel list and it ceases to look a smart idea to leave the two not matching

Alan

#4 lore raw
In reply to Alan Cox
Quoted 7 lines
Quoted 2 lines

FYI - The full tarball already has the missing patch... So, I think, it's only patch-2.4.18 that has the problem...

Argh thats the worst possible case. That means you can't do a single correct 2.4.18- patch

If so Marcelo can you put up 2.4.18-fixed patch and a borked-fixed diff ?

If this is the case... which "version" of 2.4.18 does 2.4.19-pre1 patch from?

I'm guessing it patches you from the "patched-from-2.4.17" release of 2.4.18? (if that makes sense)

Beezly

#5 lore raw
In reply to Alan Cox
Followup to:  <[email protected]>
By author:    Rik van Riel <[email protected]>
In newsgroup: linux.dev.kernel
Quoted 7 lines · Alan Cox
Quoted 2 lines

If so Marcelo can you put up 2.4.18-fixed patch and a borked-fixed diff ?

That would break hpa's incremental diff patches.
If somebody needs 2.4.18 + fix, they can just run 2.4.18-rc4.

Since the tarball apparently is OK and it's only the patch that's different, just re-create the patch, put it in the proper place, and make sure the file date on the patch is different; the incremental diff will be regenerated to match.

-hpa

Signature · 3 lines
<[email protected]> at work, <[email protected]> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt	<[email protected]>
#6 lore raw
In reply to Chris Funderburg
Quoted 7 lines · Alan Cox
Quoted 2 lines

FYI - The full tarball already has the missing patch... So, I think, it's only patch-2.4.18 that has the problem...

Argh thats the worst possible case. That means you can't do a single correct 2.4.18- patch

If so Marcelo can you put up 2.4.18-fixed patch and a borked-fixed diff ?

cdub_ and I just checked: the 18-final tarball, patch, and incr are all missing the fix in fs/binfmt_elf.c

Signature · 2 lines
Dan Chen                 [email protected]
GPG key:   www.unc.edu/~crimsun/pubkey.gpg.asc
#7 lore raw
Quoted 6 lines
Quoted 3 lines

2.4.18- patch=20
=20
If so Marcelo can you put up 2.4.18-fixed patch and a borked-fixed diff ?

cdub_ and I just checked: the 18-final tarball, patch, and incr are all missing the fix in fs/binfmt_elf.c

Cool - in which case its a non problem.

#8 lore raw
In reply to Chris Funderburg
Quoted 4 lines · Chris Funderburg

FYI - The full tarball already has the missing patch...

So, I think, it's only patch-2.4.18 that has the problem...

Uh, no, it doesn't. Using linux-2.4.18.tar.bz2 dated Feb 25, 2002 11:40am:

Makefile +1 -1
diff -urN linux-2.4.18-rc4/Makefile linux-2.4.18/Makefile
@@ -1,7 +1,7 @@
 VERSION = 2
 PATCHLEVEL = 4
 SUBLEVEL = 18
-EXTRAVERSION = -rc4
+EXTRAVERSION =
 
 KERNELRELEASE=$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)
 
fs/binfmt_elf.c +0 -0
diff -urN linux-2.4.18-rc4/fs/binfmt_elf.c linux-2.4.18/fs/binfmt_elf.c
@@ -564,9 +564,6 @@
 			// printk(KERN_WARNING "ELF: Ambiguous type, using

ELF\n");
interpreter_type = INTERPRETER_ELF;
}
- } else {
- /* Executables without an interpreter also need a
personality */
- SET_PERSONALITY(elf_ex, ibcs2_interpreter);
}

/* OK, we are done with that, now set up the arg stuff,

#9 lore raw
In reply to Chris Funderburg
Quoted 1 line · In article <[email protected]> you wrote:

So, I think, it's only patch-2.4.18 that has the problem...

Which is a pretty serious problem. Because ppl using patches hav different source from ppl using tarball. This will get a lot of confusion for the 2.4.19 patch. I suggest to fix the 2.4.18 patch, even it this is not the best method to keep unique version numbers.

Greetings
Bernd