Skip to contentSkip to conversation

pm storing void * in int

PATCH Pavel Machek 1 participant 1 message Mar 4, 2002

Subsystems (3)
Suspend to RAM Hibernation Power management core
lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

Hi!

...which is no-no for 64bit apps. (In case you wonder, data in pm.c is void *). Please apply,
Pavel

include/linux/pm.h +2 -2
@@ -103,8 +103,8 @@
 	void		*data;
 
 	unsigned long	 flags;
-	int		 state;
-	int		 prev_state;
+	unsigned long	 state;
+	unsigned long	 prev_state;
 
 	struct list_head entry;
 };
kernel/pm.c +1 -1
@@ -162,7 +162,7 @@
 	case PM_SUSPEND:
 	case PM_RESUME:
 		prev_state = dev->state;
-		next_state = (int) data;
+		next_state = (unsigned long) data;
 		if (prev_state != next_state) {
 			if (dev->callback)
 				status = (*dev->callback)(dev, rqst, data);
Signature · 2 lines
(about SSSCA) "I don't say this lightly.  However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa