Skip to contentSkip to conversation

IDE TCQ #4

PATCH Sebastian Droege 4 participants 4 messages Apr 16, 2002 – Apr 18, 2002 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 11 lines · On Tue, 16 Apr 2002 20:09:14 +0200 Jens Axboe <[email protected]> wrote:
Quoted 4 lines · Sebastian Droege

Hi,
just one short question:
My hda supports TCQ but my hdb doesn't
Is it safe to enable TCQ in kernel config?

yes, should be safe.

Signature · 1 line
Jens Axboe

Ok it really works ;)
But there's another problem in 2.5.8 with ide patches until 37 applied (they don't appear with 2.5.8 and ide patches until 35), the unexpected interrupts (look at the relevant dmesg output at the bottom). They appear with and without TCQ enabled. If you need more informations, just ask :)

Bye

Uniform Multi-Platform E-IDE driver ver.:7.0.0
ide: system bus speed 33MHz
Intel Corp. 82371AB PIIX4 IDE: IDE controller on PCI slot 00:07.1 Intel Corp. 82371AB PIIX4 IDE: chipset revision 1
Intel Corp. 82371AB PIIX4 IDE: not 100% native mode: will probe irqs later
PIIX: Intel Corp. 82371AB PIIX4 IDE UDMA33 controller on pci00:07.1

    ide0: BM-DMA at 0xf000-0xf007, BIOS settings: hda:DMA, hdb:DMA
    ide1: BM-DMA at 0xf008-0xf00f, BIOS settings: hdc:DMA, hdd:DMA

hda: IBM-DTTA-351010, ATA DISK drive
hdb: WDC WD800BB-00BSA0, ATA DISK drive
hdc: CD-W512EB, ATAPI CD/DVD-ROM drive
hdd: CD-532E-B, ATAPI CD/DVD-ROM drive
ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
ide1 at 0x170-0x177,0x376 on irq 15
ide: unexpected interrupt 0 14
hda: tagged command queueing enabled, command queue depth 32
hda: 19807200 sectors (10141 MB) w/466KiB Cache, CHS=19650/16/63, UDMA(33)
ide: unexpected interrupt 0 14
hdb: 156301488 sectors (80026 MB) w/2048KiB Cache, CHS=155061/16/63, UDMA(33)
ide: unexpected interrupt 1 15
Partition check:
/dev/ide/host0/bus0/target0/lun0: [PTBL] [1232/255/63] p1 p2 /dev/ide/host0/bus0/target1/lun0: p1 p2

#2 lore raw
Quoted 12 lines · Martin Dalecki
Quoted 11 lines · Jens Axboe
Quoted 9 lines · Martin Dalecki
Quoted 7 lines · Jens Axboe
Quoted 2 lines · Martin Dalecki

BTW> Jens: Do you have any idea what the "sector chaing" in ide-cd is good for?! I would love to just get rid of it alltogether!

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Sector chaining? Are you talking about the cdrom_read_intr() comments?

Sorry I did mean sector caching.

That's for padding/caching sub-frame sized reads.

I tought the BIO layer did this alredy... Well it's a pain

Nope, it does not.

Quoted 1 line

in the a** to deal with it. IDE-FLOPPY is passing packet commands

It sure is... sr doesn't do it and lots of others don't as well, so I suppose we could rip it out. We already require reblocking with loop in those cases anyway.

Quoted 2 lines

through the request buffer but IDE-CD is passing them through request special field... argh!

So kill ->special usage in ide-cd and use ->buffer?

Signature · 1 line
Jens Axboe
#3 lore raw
Quoted 3 lines

It sure is... sr doesn't do it and lots of others don't as well, so I suppose we could rip it out. We already require reblocking with loop in those cases anyway.

For the file system ones. It would be nice to be able to handle non power of two block sizes as well through the block interface (even if it means we hand back a 4K buffer that the caller is required to know is partly full). That would remove a lot of special case magic for audio/video

#4 lore raw
In reply to Sebastian Droege
Quoted 39 lines · Jens Axboe
Quoted 16 lines · Martin Dalecki
Quoted 14 lines · Jens Axboe
Quoted 11 lines · Martin Dalecki
Quoted 8 lines · Jens Axboe
Quoted 2 lines · Martin Dalecki

BTW> Jens: Do you have any idea what the "sector chaing" in ide-cd is good for?! I would love to just get rid of it alltogether!

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Sector chaining? Are you talking about the cdrom_read_intr() comments?

Sorry I did mean sector caching.

That's for padding/caching sub-frame sized reads.

I tought the BIO layer did this alredy... Well it's a pain

Nope, it does not.

Quoted 1 line

in the a** to deal with it. IDE-FLOPPY is passing packet commands

It sure is... sr doesn't do it and lots of others don't as well, so I suppose we could rip it out. We already require reblocking with loop in those cases anyway.

Quoted 5 lines
Quoted 2 lines

through the request buffer but IDE-CD is passing them through request special field... argh!

So kill ->special usage in ide-cd and use ->buffer?

That's the idea, but the caching code mentioned above is abusing it already in a way I can't grasp wholly immediately.

Quoted 1 line
Signature · 3 lines
- phone: +49 214 8656 283
- job:   eVision-Ventures AG, LEV .de (MY OPINIONS ARE MY OWN!)
- langs: de_DE.ISO8859-1, en_US, pl_PL.ISO8859-2, last ressort: ru_RU.KOI8-R