Skip to contentSkip to conversation

double down() in nfsd_symlink

PATCH New Anton Blanchard 1 participant 1 message Apr 21, 2002 NFS server

lore
Share & tools
lore

Anton Blanchard

author
#0 lore raw

PATCH 1/1 double down() in nfsd_symlink

Hi,

Probably as a result of the recent BKL removal in notify_change, nfsd_symlink downs the inode semaphore twice (the first time is in fh_lock). Al does this patch look OK to you?

fs/nfsd/vfs.c +0 -2
@@ -1127,9 +1127,7 @@
 				iap->ia_valid |= ATTR_CTIME;
 				iap->ia_mode = (iap->ia_mode&S_IALLUGO)
 					| S_IFLNK;
-				down(&dentry->d_inode->i_sem);
 				err = notify_change(dnew, iap);
-				up(&dentry->d_inode->i_sem);
 				if (!err && EX_ISSYNC(fhp->fh_export))
 					write_inode_now(dentry->d_inode, 1);
 		       }

Anton