exporting task_nice in O(1)-sched
Hi.
Found this building bproc. New O(1) scheduler kills the nice field in task struct. It gives a way to fix the niceness (set_user_nice()), but the funtion to _query_ is not exported. Any particular reason ?
Patch:
kernel/ksyms.c renamed from kernel/ksyms.c.org +1 -0
@@ -455,6 +455,7 @@EXPORT_SYMBOL (schedule_timeout);EXPORT_SYMBOL (sys_sched_yield);EXPORT_SYMBOL (set_user_nice); +EXPORT_SYMBOL (task_nice);#ifdef CONFIG_SMP EXPORT_SYMBOL_GPL (set_cpus_allowed);#endif
Signature · 4 lines
J.A. Magallon # Let the source be with you... mailto:[email protected] Mandrake Linux release 8.3 (Cooker) for i586 Linux werewolf 2.4.19-pre7-jam6 #2 SMP mar abr 23 16:56:56 CEST 2002 i686
Quoted 3 lines · J.A. Magallon
Found this building bproc. New O(1) scheduler kills the nice field in task struct. It gives a way to fix the niceness (
set_user_nice()), but the funtion to _query_ is not exported. Any particular reason ?
Probably because Ingo intended to hide as many interfaces to the scheduler as possible and only export those symbols that were needed.
It is safe to export if it is needed.
Robert Love
Quoted 11 lines · Robert Love
Quoted 3 lines · J.A. Magallon
Found this building bproc. New O(1) scheduler kills the nice field in task struct. It gives a way to fix the niceness (
set_user_nice()), but the funtion to _query_ is not exported. Any particular reason ?Probably because Ingo intended to hide as many interfaces to the scheduler as possible and only export those symbols that were needed.
It is safe to export if it is needed.
Seems kind of silly to be able to set it but not read it...
Signature · 4 lines
Chris Friesen | MailStop: 043/33/F10 Nortel Networks | work: (613) 765-0557 3500 Carling Avenue | fax: (613) 765-2986 Nepean, ON K2H 8E9 Canada | email: [email protected]