Skip to contentSkip to conversation

Warn about trap for programmer in mm.h

PATCH Pavel Machek 5 participants 5 messages Apr 25, 2002 – Apr 26, 2002 MM core

lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

Hi!

As suggested by A.Morton:
Pavel

include/linux/mm.h +1 -1
@@ -291,8 +291,8 @@
 #define PG_arch_1		13
 #define PG_reserved		14
 #define PG_launder		15	/* written out by VM pressure.. */
-
 #define PG_private		16	/* Has something at ->private */
+/* Top 8 bits are used for page's zone in 2.4-ac and 2.5, don't use them */
 
 /* Make it prettier to test the above... */
 #define UnlockPage(page)	unlock_page(page)
Signature · 2 lines
(about SSSCA) "I don't say this lightly.  However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa
#1 lore raw
Quoted 3 lines · Pavel Machek

#define PG_private 16 /* Has something at ->private */
+/* Top 8 bits are used for page's zone in 2.4-ac and 2.5, don't use them */

Erm, and 2.4 mainline these days isn't it?

Signature · 2 lines
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
#2 lore raw
In reply to Pavel Machek
Quoted 8 lines · Pavel Machek

Hi!

As suggested by A.Morton:
Pavel

include/linux/mm.h line 295

Quoted 6 lines
include/linux/mm.h +1 -1
@@ -291,8 +291,8 @@
 #define PG_arch_1		13
 #define PG_reserved		14
 #define PG_launder		15	/* written out by VM pressure.. */
-
 #define PG_private		16	/* Has something at ->private */
+/* Top 8 bits are used for page's zone in 2.4-ac and 2.5, don't use them */

s/in 2.4-ac and 2.5//

#3 lore raw
In reply to Pavel Machek

Hi!

Quoted 5 lines
Quoted 3 lines

#define PG_private 16 /* Has something at ->private */
+/* Top 8 bits are used for page's zone in 2.4-ac and 2.5, don't use them */

Erm, and 2.4 mainline these days isn't it?

Rusty, its up to you. You can s/2.4-ac and 2.5//, but it is "correct" in any way ;-).
Pavel

Signature · 2 lines
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.
#4 lore raw
In reply to Pavel Machek

From: Pavel Machek <[email protected]>
Date: Thu, 25 Apr 2002 12:04:40 +0200

As suggested by A.Morton:
... Pavel

    #define PG_launder		15	/* written out by VM pressure.. */
   -
    #define PG_private		16	/* Has something at ->private */

+/* Top 8 bits are used for page's zone in 2.4-ac and 2.5, don't use them */

What does top 8 bites mean on a type whose size
is dependent upon the architecture? :-)