linux-2.5.x-dj and SCSI error handling.
Folks, I just woke up to about a dozen reports of the same 'bug' all with patches which are so wrong they stand no chance of application by me or Linus, posting here is quicker than me pointing those people (and those who may follow them) to the answer.
The recent patch from Christoph Hellwig which kills off the last remaining remnants of the old style SCSI error handling. The reason these drivers no longer compile due to missing 'abort' and 'reset' functions is due to the fact that they need converting to new-style error handling.
For instructions on how to do this, read http://www.andante.org/scsi_eh.html
For instructions on how not to this..
o Do not send me patches that just remove the reset: and abort:
functions. This gives us no error handling whatsoever.
o Do not send me patches re-adding the 'missing' reset & abort functions
to the Scsi_Host_Template struct. This gets us nowhere.
o Yes, I know ide-scsi, and various other scsi drivers are broken.
Fix them, or be patient and wait for them to be fixed.
Dave.
Signature · 2 lines
| Dave Jones. http://www.codemonkey.org.uk | SuSE Labs
Quoted 5 lines · In article <[email protected]> you wrote:
For instructions on how not to this..
o Do not send me patches that just remove the reset: and abort:
functions. This gives us no error handling whatsoever.
o Do not send me patches re-adding the 'missing' reset & abort functions
to theScsi_Host_Templatestruct. This gets us nowhere.
And this also gives you no error handling whatsoever......
Hello Dave , Might be nice to also mention the drivers that were being complained about . So there respective mantainers can benifit from your email . Tia , JimL
Quoted 13 lines · Dave Jones
Folks, I just woke up to about a dozen reports of the same 'bug' all with patches which are so wrong they stand no chance of application by me or Linus, posting here is quicker than me pointing those people (and those who may follow them) to the answer.
The recent patch from Christoph Hellwig which kills off the last remaining remnants of the old style SCSI error handling. The reason these drivers no longer compile due to missing 'abort' and 'reset' functions is due to the fact that they need converting to new-style error handling.
For instructions on how to do this, read http://www.andante.org/scsi_eh.html
Quoted 8 lines
For instructions on how not to this..
o Do not send me patches that just remove the reset: and abort:
functions. This gives us no error handling whatsoever.
o Do not send me patches re-adding the 'missing' reset & abort functions
to theScsi_Host_Templatestruct. This gets us nowhere.
o Yes, I know ide-scsi, and various other scsi drivers are broken.
Fix them, or be patient and wait for them to be fixed. Dave.
+------------------------------------------------------------------+
| James W. Laferriere | System Techniques | Give me VMS |
| Network Engineer | P.O. Box 854 | Give me Linux |
| [email protected] | Coudersport PA 16915 | only on AXP |
+------------------------------------------------------------------+Quoted 3 lines · Mr. James W. Laferriere
Hello Dave , Might be nice to also mention the drivers that were being complained about . So there respective mantainers can benifit from your email . Tia , JimL
noted. I'll do a full compile later today and post back the list of drivers broken due to this issue. The only one everyone seems to be complaining about is ide-scsi, but there are definitly others.
Dave.
Signature · 2 lines
| Dave Jones. http://www.codemonkey.org.uk | SuSE Labs