Skip to contentSkip to conversation

Linux 2.5.12-dj1

DISCUSSION [email protected] 3 participants 3 messages May 2, 2002 – May 3, 2002

lore
Share & tools
lore
#0 lore raw

This is the output while compiling aic7xxx_old.c:

aic7xxx_old.c:11950: unknown field abort' specified in initializer aic7xxx_old.c:11950: warning: initialization from incompatible pointer type aic7xxx_old.c:11950: unknown field reset' specified in initializer aic7xxx_old.c:11950: warning: initialization from incompatible pointer type aic7xxx_old.c:11950: duplicate initializer
aic7xxx_old.c:11950: (near initialization for `driver_template.slave_attach') aic7xxx_old.c:11950: duplicate initializer
aic7xxx_old.c:11950: (near initialization for `driver_template.bios_param') make[3]: *** [aic7xxx_old.o] Error 1

aic7xxxx_old.c compiles in 2.5.12 and 2.5.7-dj3, although it may be broken in some other way.

Is it appropriate to edit .config to use the new driver by setting:
CONFIG_SCSI_AIC7XXX=y
CONFIG_AIC7XXX_CMDS_PER_DEVICE=253 CONFIG_AIC7XXX_RESET_DELAY_MS=15000

Is the new driver experimental, or ?

Signature · 1 line
Randy Hron
#1 lore raw
Quoted 4 lines · On Thu, May 02, 2002 at 07:20:10AM -0400, [email protected] wrote:

This is the output while compiling aic7xxx_old.c:

aic7xxx_old.c:11950: unknown field abort' specified in initializer aic7xxx_old.c:11950: unknown field reset' specified in initializer

Stereotypical "needs error handling code" errors.

Quoted 2 lines

aic7xxxx_old.c compiles in 2.5.12 and 2.5.7-dj3, although it may be broken in some other way.

Yep. Removal of the abort/reset methods shows us which SCSI drivers don't have any error handling. So they 'worked' up until you got an error, and then...

Quoted 5 lines

Is it appropriate to edit .config to use the new driver by setting:
CONFIG_SCSI_AIC7XXX=y
CONFIG_AIC7XXX_CMDS_PER_DEVICE=253 CONFIG_AIC7XXX_RESET_DELAY_MS=15000
Is the new driver experimental, or ?

I've no experience of either driver in practice, so I'm not actually sure what the game plan is here. Someone want to fill us in? Justin?

Signature · 2 lines
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
#2 lore raw
Quoted 8 lines
Quoted 5 lines

Is it appropriate to edit .config to use the new driver by setting:
CONFIG_SCSI_AIC7XXX=y
CONFIG_AIC7XXX_CMDS_PER_DEVICE=253 CONFIG_AIC7XXX_RESET_DELAY_MS=15000
Is the new driver experimental, or ?

I've no experience of either driver in practice, so I'm not actually sure what the game plan is here. Someone want to fill us in? Justin?

Since I have not reviewed how the driver has been modified for 2.5, I can't really say much about its status in that branch. The driver is not "experimental" in the 2.4 branch.

--
Justin