Skip to contentSkip to conversation

get_ma_area() function

Q Andrey Panin 2 participants 2 messages May 7, 2002

lore
Share & tools
lore
#0 lore raw

Hi,

looking at mm/vmalloc.c i found one strange (for me) line of code.

From mm/vmalloc.c:

struct vm_struct * get_vm_area(unsigned long size, unsigned long flags)

{
	unsigned long addr;
	struct vm_struct **p, *tmp, *area;

	area = (struct vm_struct *) kmalloc(sizeof(*area), GFP_KERNEL);
	if (!area)
		return NULL;
	size += PAGE_SIZE;
	^^^^^^^^^^^^^^^^^^

Why ? Maybe size = PAGE_ALIGN(size); is more correct here ?

Best regards.

Signature · 2 lines
Andrey Panin            | Embedded systems software engineer
[email protected]        | PGP key: wwwkeys.eu.pgp.net
#1 lore raw
Quoted 15 lines · Andrey Panin

looking at mm/vmalloc.c i found one strange (for me) line of code.

From mm/vmalloc.c:

struct vm_struct * get_vm_area(unsigned long size, unsigned long flags)

{
	unsigned long addr;
	struct vm_struct **p, *tmp, *area;

	area = (struct vm_struct *) kmalloc(sizeof(*area), GFP_KERNEL);
	if (!area)
		return NULL;
	size += PAGE_SIZE;
	^^^^^^^^^^^^^^^^^^
Quoted 1 line

Why ? Maybe size = PAGE_ALIGN(size); is more correct here ?

No, __vmalloc already did the size = PAGE_ALIGN(size).
Here it is intentionally adding one page to the virtual allocation size, to leave one invalid guard or fence page between vmalloc'ed allocations, to trap overruns from one area to the next. You're right, a comment would be appropriate there.

Hugh