Skip to contentSkip to conversation

ia64 code having CONFIG_X86_LOCAL_APIC

DISCUSSION Ravikiran G Thirumalai 2 participants 2 messages May 23, 2002

lore
Share & tools
lore
#0 lore raw

Hi folks,
linux-2.5.17/arch/ia64/kernel/irq.c has a
#ifdef CONFIG_X86_LOCAL_APIC,
but I dont see the config option in any ia64 config.in files..... wondering if this is just some piece of code which will never be compiled...

Also, linux-2.5.17/arch/ia64/kernel/irq.c prints apic_timer_irqs, and they don't seem to be defined for ia64. The piece of code (irq.c) is also covered by
#ifdef CONFIG_X86
wonder if the condition is ever true.....

Pls let me know what I am missing

disclaimer: I don't know much about ia64

Kiran

#1 lore raw

There is a simple reason for this: the goal is (or at least "was") that irq.c would eventually become platform-independent. To prepare for this, I keep the ia64 version of irq.c as much in sync with the x86 version as possible (actually, I haven't check recently, so there may have been some divergence while I wasn't watching). So, yes, there is some dead code in the ia64 version, but it does serve the purpose to minimize the differences with the x86 version.

	--david
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Ravikiran G Thirumalai

Ravikiran> Hi folks, linux-2.5.17/arch/ia64/kernel/irq.c has a Ravikiran> #ifdef CONFIG_X86_LOCAL_APIC, but I dont see the config Ravikiran> option in any ia64 config.in files..... wondering if Ravikiran> this is just some piece of code which will never be Ravikiran> compiled...

Ravikiran> Also, linux-2.5.17/arch/ia64/kernel/irq.c prints Ravikiran> apic_timer_irqs, and they don't seem to be defined for Ravikiran> ia64. The piece of code (irq.c) is also covered by Ravikiran> #ifdef CONFIG_X86 wonder if the condition is ever Ravikiran> true.....

Ravikiran> Pls let me know what I am missing

Ravikiran> disclaimer: I don't know much about ia64

Ravikiran> Kiran

Ravikiran> - To unsubscribe from this list: send the line Ravikiran> "unsubscribe linux-kernel" in the body of a message to Ravikiran> [email protected] More majordomo info at Ravikiran> http://vger.kernel.org/majordomo-info.html Please read Ravikiran> the FAQ at http://www.tux.org/lkml/

--
Interested in learning more about IA-64 Linux? Try http://www.lia64.org/book/