Skip to contentSkip to conversation

Trivial: move PCI ID definitions from ide-pci.c to pci_ids.h

PATCH In review Vojtech Pavlik 3 participants 5 messages May 26, 2002 – May 27, 2002 PCI

lore
Share & tools
lore

Vojtech Pavlik

author
#0 lore raw

PATCH 1/1 Trivial: move PCI ID definitions from ide-pci.c to pci_ids.h

[email protected], 2002-05-26 15:19:41+02:00, [email protected]
This cset moves a PCI ID definition from ide-pci.c to pci_ids.h where it belongs.

 drivers/ide/ide-pci.c   |    6 +-----
 include/linux/pci_ids.h |    4 ++++
 2 files changed, 5 insertions(+), 5 deletions(-)
drivers/ide/ide-pci.c +1 -5
diff -Nru a/drivers/ide/ide-pci.c b/drivers/ide/ide-pci.c
@@ -27,10 +27,6 @@
 
 #include "pcihost.h"
 
-/* Missing PCI device IDs: */
-#define PCI_VENDOR_ID_HINT 0x3388
-#define PCI_DEVICE_ID_HINT 0x8013
-
 /*
  * This is the list of registered PCI chipset driver data structures.
  */

@@ -756,7 +752,7 @@
 	},
 	{
 		vendor: PCI_VENDOR_ID_HINT,
-		device: PCI_DEVICE_ID_HINT,
+		device: PCI_DEVICE_ID_HINT_VXPROII_IDE,
 		bootable: ON_BOARD
 	},
 	{
include/linux/pci_ids.h +4 -0
diff -Nru a/include/linux/pci_ids.h b/include/linux/pci_ids.h
@@ -1787,3 +1787,7 @@
 #define PCI_DEVICE_ID_MICROGATE_USC	0x0010
 #define PCI_DEVICE_ID_MICROGATE_SCC	0x0020
 #define PCI_DEVICE_ID_MICROGATE_SCA	0x0030
+
+#define PCI_VENDOR_ID_HINT		0x3388
+#define PCI_DEVICE_ID_HINT_VXPROII_IDE	0x8013
+
Signature · 2 lines
Vojtech Pavlik
SuSE Labs
#1 lore raw

Uz.ytkownik Vojtech Pavlik napisa?:

Quoted 37 lines

[email protected], 2002-05-26 15:19:41+02:00, [email protected]
This cset moves a PCI ID definition from ide-pci.c to pci_ids.h where it belongs.

 drivers/ide/ide-pci.c   |    6 +-----
 include/linux/pci_ids.h |    4 ++++
 2 files changed, 5 insertions(+), 5 deletions(-)

diff -Nru a/drivers/ide/ide-pci.c b/drivers/ide/ide-pci.c

drivers/ide/ide-pci.c +1 -5
@@ -27,10 +27,6 @@
 
 #include "pcihost.h"
 
-/* Missing PCI device IDs: */
-#define PCI_VENDOR_ID_HINT 0x3388
-#define PCI_DEVICE_ID_HINT 0x8013
-
 /*
  * This is the list of registered PCI chipset driver data structures.
  */

@@ -756,7 +752,7 @@
 	},
 	{
 		vendor: PCI_VENDOR_ID_HINT,
-		device: PCI_DEVICE_ID_HINT,
+		device: PCI_DEVICE_ID_HINT_VXPROII_IDE,
 		bootable: ON_BOARD
 	},
 	{

diff -Nru a/include/linux/pci_ids.h b/include/linux/pci_ids.h

include/linux/pci_ids.h line 1793

Quoted 7 lines
include/linux/pci_ids.h +4 -0
@@ -1787,3 +1787,7 @@
 #define PCI_DEVICE_ID_MICROGATE_USC	0x0010
 #define PCI_DEVICE_ID_MICROGATE_SCC	0x0020
 #define PCI_DEVICE_ID_MICROGATE_SCA	0x0030
+
+#define PCI_VENDOR_ID_HINT		0x3388
+#define PCI_DEVICE_ID_HINT_VXPROII_IDE	0x8013
+

Please note that pci_ids.h. is a generated file. The ids have to be moved to the ancestor of it as well.

#2 lore raw
In reply to Vojtech Pavlik
Quoted 1 line · Martin Dalecki

Please note that pci_ids.h. is a generated file.

No. You're thinking of drivers/pci/devlist.h and classlist.h If you looks at pci_ids.h, you'll notice we only have IDs in there for devices Linux actually supports.

Signature · 2 lines
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
#3 lore raw
In reply to Vojtech Pavlik

Uz.ytkownik Dave Jones napisa?:

Quoted 6 lines · Martin Dalecki
Quoted 1 line

Please note that pci_ids.h. is a generated file.

No. You're thinking of drivers/pci/devlist.h and classlist.h If you looks at pci_ids.h, you'll notice we only have IDs in there for devices Linux actually supports.

I stand corrected indeed. OK time for the next cup of coffe this morning to get me awake finally :-).

author
#4 lore raw
In reply to Vojtech Pavlik
Quoted 6 lines · Martin Dalecki
Quoted 6 lines

diff -Nru a/include/linux/pci_ids.h b/include/linux/pci_ids.h

include/linux/pci_ids.h +0 -0
@@ -1787,3 +1787,7 @@
 #define PCI_DEVICE_ID_MICROGATE_USC	0x0010
 #define PCI_DEVICE_ID_MICROGATE_SCC	0x0020
Quoted 8 lines

include/linux/pci_ids.h line 1793

Quoted 5 lines
include/linux/pci_ids.h +4 -0
 #define PCI_DEVICE_ID_MICROGATE_SCA	0x0030
+
+#define PCI_VENDOR_ID_HINT		0x3388
+#define PCI_DEVICE_ID_HINT_VXPROII_IDE	0x8013
+

Please note that pci_ids.h. is a generated file. The ids have to be moved to the ancestor of it as well.

Generated? I don't think so. devlist.h is, same for classlist.h, but not pci_ids.h

Signature · 2 lines
Vojtech Pavlik
SuSE Labs