Skip to contentSkip to conversation

trivial: reiserfs whitespace

PATCH Pavel Machek 4 participants 6 messages May 26, 2002 – May 28, 2002

lore
Share & tools
lore
#0 lore raw

Hi!

Kill space at EOLN.

Pavel

fs/reiserfs/journal.c +1 -1
@@ -57,7 +57,7 @@
 #include <linux/stat.h>
 #include <linux/string.h>
 #include <linux/smp_lock.h>
-#include <linux/suspend.h> 
+#include <linux/suspend.h>
 #include <linux/buffer_head.h>
 
 /* the number of mounted filesystems.  This is used to decide when to
Signature · 2 lines
(about SSSCA) "I don't say this lightly.  However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa
#1 lore raw

On Sun, May 26, 2002 at 08:31:28PM +0200, Pavel Machek wrote:

Kill space at EOLN.

I have a trivial script to remove this for an entire tree. I decided it was a bad idea when I saw how many lines are indeed affected.

--cw

#2 lore raw
In reply to Pavel Machek

Em Sun, May 26, 2002 at 07:43:54PM -0700, Chris Wedgwood escreveu:

Quoted 6 lines · Pavel Machek

Kill space at EOLN.

I have a trivial script to remove this for an entire tree. I decided it was a bad idea when I saw how many lines are indeed affected.

But doing it slowly, together with other patches, is not a bad idea.

- Arnaldo

#3 lore raw
In reply to Pavel Machek

Hi!

Quoted 4 lines

Kill space at EOLN.

I have a trivial script to remove this for an entire tree. I decided it was a bad idea when I saw how many lines are indeed affected.

It was my fault it got introduced, so I thought it is my responsibility to kill it.
Pavel

Signature · 2 lines
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.
#4 lore raw
In reply to Pavel Machek

On Sat, May 25, 2002 at 11:53:25AM -0300, Arnaldo Carvalho de Melo wrote:

But doing it slowly, together with other patches, is not a bad idea.

Well, in that case is there some kind of bk or command that can be made to automagically run to purge white-space from the end patches/changesets as they are produced? It would also be nice to have hunks such as[1]:

     --- 1   Tue May 28 00:56:35 2002
     +++ 2   Tue May 28 00:56:34 2002
     @@ -1 +1 @@
     -  
     +		

stripped completely as they have no functional value and just add bloat patches and such like.

This can be done with CVS but as it works very differently to bk (which to be honest I really don't understand very well at all) I'm not even sure if the above suggestion is meaningful.

--cw

[1] View this email with something that makes white-space visible.

    Basically, 1 is ' ' and 2 is '\t\t'.
#5 lore raw
In reply to Pavel Machek
Quoted 16 lines · Chris Wedgwood

On Sat, May 25, 2002 at 11:53:25AM -0300, Arnaldo Carvalho de Melo wrote:

But doing it slowly, together with other patches, is not a bad idea.

Well, in that case is there some kind of bk or command that can be made to automagically run to purge white-space from the end patches/changesets as they are produced? It would also be nice to have hunks such as[1]:

     --- 1   Tue May 28 00:56:35 2002
     +++ 2   Tue May 28 00:56:34 2002
     @@ -1 +1 @@
     -  
     +		
Quoted 8 lines

stripped completely as they have no functional value and just add bloat patches and such like.

This can be done with CVS but as it works very differently to bk (which to be honest I really don't understand very well at all) I'm not even sure if the above suggestion is meaningful.

   --cw

CW makes an interesting point. Perhaps bk could be configured to check for / +\t/ and /\s+$/ on changed lines, and possibly their contigious neighbors, and ask about purging the superfluous whitespace. Comments Larry?

Signature · 5 lines
________________________________________________________________
	J.W. Schultz            Pegasystems Technologies
	email address:		[email protected]

		Remember Cernan and Schmitt