Skip to contentSkip to conversation

Bug in asm-i386/rwlock.h

PATCH Alexey Vyskubov 1 participant 1 message Jun 4, 2002

lore
Share & tools
lore
#0 lore raw

Hello.

We suppose that include/asm-i386/rwlock.h contains a bug.

Under some circumstances (compiling some external modules + no optimization + SMP) it's possible to get the following error:

/tmp/ccw7qDe1.s: Assembler messages:
/tmp/ccw7qDe1.s:6815: Error: bad expression /tmp/ccw7qDe1.s:6815: Error: missing ')' /tmp/ccw7qDe1.s:6815: Error: missing ')' /tmp/ccw7qDe1.s:6815: Error: junk `ebx))' after expression

We believe that it's a typo in include/asm-i386/rwlock.h

asm-i386/rwlock.h Tue Jun 4 16:33:02 2002 renamed from asm-i386/rwlock.h.orig Tue Jun 4 16:32:38 2002 +1 -1
@@ -61,7 +61,7 @@
                     ::"a" (rw) : "memory")
 
 #define __build_write_lock_const(rw, helper) \
-       asm volatile(LOCK "subl $" RW_LOCK_BIAS_STR ",(%0)\n\t" \
+       asm volatile(LOCK "subl $" RW_LOCK_BIAS_STR ",%0\n\t" \
                     "jnz 2f\n" \
                     "1:\n" \
                     ".section .text.lock,\"ax\"\n" \
Signature · 3 lines
Alexey Vyskubov
Dmitry Kasatkin
Nokia Research Center / Helsinki