Skip to contentSkip to conversation

Allow mpage.c to build

PATCH In review Russell King 3 participants 3 messages Jun 5, 2002 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Allow mpage.c to build

Linus,

When trying to build mpage.c for ARM, I get errors from bio.h since kdev_t isn't defined. The following fixes this.

(I fail to see how this can build for anyone as it currently stands; its probably something x86 specific buried in the asm-i386 includes.)

fs/mpage.c +1 -0
@@ -12,6 +12,7 @@
 
 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/kdev_t.h>
 #include <linux/bio.h>
 #include <linux/fs.h>
 #include <linux/buffer_head.h>
Signature · 2 lines
Russell King ([email protected])                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html
#1 lore raw
Quoted 10 lines · Russell King

Linus,

When trying to build mpage.c for ARM, I get errors from bio.h since kdev_t isn't defined. The following fixes this.

(I fail to see how this can build for anyone as it currently stands; its probably something x86 specific buried in the asm-i386 includes.)

...

/usr/src/25/include/linux/bio.h
/usr/src/25/include/asm/io.h
/usr/src/25/include/linux/vmalloc.h
/usr/src/25/include/linux/mm.h

    /usr/src/25/include/linux/swap.h
     /usr/src/25/include/linux/kdev_t.h

Lovely, isn't it?

-

#2 lore raw
In reply to Russell King
Quoted 4 lines · Andrew Morton

/usr/src/25/include/linux/bio.h
/usr/src/25/include/asm/io.h
/usr/src/25/include/linux/vmalloc.h
/usr/src/25/include/linux/mm.h

                                ^^^^^

This bugger should be high on the list of include files that need feeding through the include-chopper-upper.

Quoted 3 lines
    /usr/src/25/include/linux/swap.h
     /usr/src/25/include/linux/kdev_t.h

Lovely, isn't it?

Wouldn't be so bad if it were an isolated case.. Hopefully by the time we get to 2.6, a lot of this 'include by implication' nonsense can be cleaned up some more.

Dave.

Signature · 2 lines
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs