pageattr update
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 8 lines · David Mosberger
As long as
change_page_attr()is used for AGP-related stuff only, there is probably no real issue with the patch in its current form (its simply a no-op on most non-x86 platforms). However, I'm a bit worried that someone might start to use it for other things, such thatchange_page_attr()could no longer be a no-op on those platforms. Since the DMA coherency issue is an AGP specific issue, perhaps just renaming the macro toagp_change_page_attr()would take care of my concern. What do you think
Linus already requested that for 2.5 (agp_map_into_gart() etc.) I think for 2.4 #ifdef in the agp code is fine and I'm not adopting Ben's change of moving change_page_attr into all asm files.
-Andi