beautify nr_free_pages()
Subsystems (2)
nr_free_pages() is overly verbose. The following is perhaps clearer and gets to the point with fewer lines of code and inside of 80 columns.
Against 2.5.21
Cheers,
Bill
===== mm/page_alloc.c 1.67 vs edited =====
mm/page_alloc.c +6 -9
@@ -495,16 +495,13 @@*/ unsigned int nr_free_pages (void ) { -unsigned int sum; -zone_t *zone; -pg_data_t *pgdat = pgdat_list; +unsigned int i, sum =0 ; +pg_data_t *pgdat; + +for (pgdat = pgdat_list; pgdat; pgdat = pgdat->node_next) +for (i =0 ; i <MAX_NR_ZONES ; ++i) + sum += pgdat->node_zones[i].free_pages; - sum =0 ; -while (pgdat) { -for (zone = pgdat->node_zones; zone < pgdat->node_zones +MAX_NR_ZONES ; zone++) - sum += zone->free_pages; - pgdat = pgdat->node_next; - }return sum; }