Skip to contentSkip to conversation

NFS nonzero preempt_count 1/2

PATCH William Lee Irwin III 2 participants 2 messages Jul 16, 2002

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

When unmounting an NFS filesystem, I saw printk's reporting that NFS daemons exited with nonzero preempt_counts. Fixing this up so they no longer give the warning seems like a good idea.

Patch attempting to do this for rpciod below.

Cheers,
Bill

===== net/sunrpc/sched.c 1.15 vs edited =====

net/sunrpc/sched.c +1 -0
@@ -1088,6 +1088,7 @@
 	wake_up(assassin);
 
 	dprintk("RPC: rpciod exiting\n");
+	unlock_kernel();
 	MOD_DEC_USE_COUNT;
 	return 0;
 }
#1 lore raw

Hi,

net/sunrpc/sched.c line 1094

Quoted 8 lines · William Lee Irwin III
net/sunrpc/sched.c +1 -0
@@ -1088,6 +1088,7 @@
 	wake_up(assassin);
 
 	dprintk("RPC: rpciod exiting\n");
+	unlock_kernel();
 	MOD_DEC_USE_COUNT;
 	return 0;
 }

I wonder why the checker didn't yell on this. Wasn't it in the tree when the checker checked?

Regards, Thunder

Signature · 7 lines
(Use http://www.ebb.org/ungeek if you can't decode)
------BEGIN GEEK CODE BLOCK------
Version: 3.12
GCS/E/G/S/AT d- s++:-- a? C++$ ULAVHI++++$ P++$ L++++(+++++)$ E W-$
N--- o?  K? w-- O- M V$ PS+ PE- Y- PGP+ t+ 5+ X+ R- !tv b++ DI? !D G
e++++ h* r--- y- 
------END GEEK CODE BLOCK------