Skip to contentSkip to conversation

__func__ in 2.5.33?

DISCUSSION Rasmus Andersen 2 participants 3 messages Sep 3, 2002 – Sep 4, 2002

lore
Share & tools
lore
#0 lore raw

Hi,

I trying to compile the SX driver for the 2.5.33 kernel, I got a lot of warnings looking like (this is from a test program, not the driver itself)

test.c: In function `main':
test.c:6: called object is not a function
test.c:6: parse error before string constant

This seems to stem from the recent __FUNCTION__ vs. __func__ change in kernel.h and the SX driver's use of __FUNCTION__ in the following construct

#define func_enter() sx_dprintk (SX_DEBUG_FLOW, "sx: enter " __FUNCTION__ "\n")

My gcc (vers. 2.96) does not accept the above when __FUNCTION__ is #defined to be (__func__). I likes __func__ well enough, though.

So I guess my question is whether I should change the above define, and if so, to what, or if __FUNCTION__ should be defined to something else?

BTW, it was my impression that the kernel would continue with __FUNCTION__? Maybe I missed something....

Regards,
Rasmus

#1 lore raw
Quoted 11 lines · Rasmus Andersen

Hi,

I trying to compile the SX driver for the 2.5.33 kernel, I got a lot of warnings looking like (this is from a test program, not the driver itself)

test.c: In function `main':
test.c:6: called object is not a function
test.c:6: parse error before string constant

Quoted 6 lines

This seems to stem from the recent __FUNCTION__ vs. __func__ change in kernel.h and the SX driver's use of __FUNCTION__ in the following construct

#define func_enter() sx_dprintk (SX_DEBUG_FLOW, "sx: enter " __FUNCTION__ "\n")

The parenthesised (__func__) is there to force you to not try to perform this string pasting. Support for __FUNCTION__ pasting is being phased out of gcc.

You need:

#define func_enter() sx_dprintk (SX_DEBUG_FLOW, "sx: enter %s\n", __FUNCTION__)

#2 lore raw
Quoted 7 lines · Andrew Morton

The parenthesised (__func__) is there to force you to not try to perform this string pasting. Support for __FUNCTION__ pasting is being phased out of gcc.

You need:

#define func_enter() sx_dprintk (SX_DEBUG_FLOW, "sx: enter %s\n", __FUNCTION__)

Ah, OK. I apparently missed the part about the pasting part being phased out, alongside missing Paul Larson's patch.

Thanks to both of you,
Rasmus