Skip to contentSkip to conversation

In-kernel module loader 5/7

PATCH In review Rusty Russell 2 participants 3 messages Sep 18, 2002

lore
Share & tools
lore

Rusty Russell

author
#0 lore raw

PATCH 1/1 In-kernel module loader 5/7

Name: Every module needs module_init
Author: Rusty Russell
Status: Trivial

D: Every module needs a module_init now, so insert a trivial one where
D: needed. This is not exhaustive.

lib/zlib_deflate/deflate_syms.c +6 -0
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .17783-2.5.35-modbase-try-i386.pre/lib/zlib_deflate/deflate_syms.c .17783-2.5.35-modbase-try-i386/lib/zlib_deflate/deflate_syms.c
@@ -19,3 +19,9 @@ EXPORT_SYMBOL(zlib_deflateReset);
 EXPORT_SYMBOL(zlib_deflateCopy);
 EXPORT_SYMBOL(zlib_deflateParams);
 MODULE_LICENSE("GPL");
+
+static int init(void)
+{
+	return 0;
+}
+module_init(init);
lib/zlib_inflate/inflate_syms.c +6 -0
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .17783-2.5.35-modbase-try-i386.pre/lib/zlib_inflate/inflate_syms.c .17783-2.5.35-modbase-try-i386/lib/zlib_inflate/inflate_syms.c
@@ -20,3 +20,9 @@ EXPORT_SYMBOL(zlib_inflateReset);
 EXPORT_SYMBOL(zlib_inflateSyncPoint);
 EXPORT_SYMBOL(zlib_inflateIncomp); 
 MODULE_LICENSE("GPL");
+
+static int init(void)
+{
+	return 0;
+}
+module_init(init);

--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

#1 lore raw
Quoted 11 lines · On 2002.09.18 Rusty Russell wrote:

Name: Every module needs module_init
Author: Rusty Russell
Status: Trivial

D: Every module needs a module_init now, so insert a trivial one where
D: needed. This is not exhaustive.

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .17783-2.5.35-modbase-try-i386.pre/lib/zlib_deflate/deflate_syms.c .17783-2.5.35-modbase-try-i386/lib/zlib_deflate/deflate_syms.c

lib/zlib_deflate/deflate_syms.c EXPORT_SYMBOL(zlib_deflateReset); · line 27

Quoted 9 lines
lib/zlib_deflate/deflate_syms.c +6 -0
@@ -19,3 +19,9 @@ EXPORT_SYMBOL(zlib_deflateReset);
 EXPORT_SYMBOL(zlib_deflateCopy);
 EXPORT_SYMBOL(zlib_deflateParams);
 MODULE_LICENSE("GPL");
+
+static int init(void)
+{
+	return 0;
+}
+module_init(init);

Would not be worthy to do something like

#define MODULE_INIT_DEFAULT \
static int init(void) { return o;} \
module_init(init)
...

so you just can add:

MODULE_INIT_DEFAULT;
MODULE_EXIT_DEFAULT;

Signature · 4 lines
J.A. Magallon <[email protected]>      \                 Software is like sex:
werewolf.able.es                         \           It's better when it's free
Mandrake Linux release 9.0 (Cooker) for i586
Linux 2.4.20-pre7-jam1 (gcc 3.2 (Mandrake Linux 9.0 3.2-1mdk))
author
#2 lore raw

In message <[email protected]> you write:

Quoted 11 lines

Would not be worthy to do something like

#define MODULE_INIT_DEFAULT \
static int init(void) { return o;} \
module_init(init)
...

so you just can add:

MODULE_INIT_DEFAULT;
MODULE_EXIT_DEFAULT;

Hmmm... I didn't do that because I want people to *think* about init and exit issues, and because most modules *do* need some initialization.

Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.