Skip to contentSkip to conversation

__KERNEL__ pasting in drivers/net/wan/cycx_x25.c

PATCH In review [email protected] 2 participants 2 messages Sep 21, 2002 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 __KERNEL__ pasting in drivers/net/wan/cycx_x25.c

This patch cleans up the __FUNCTION__ pasting to the new standard.

Adam

net/wan/cycx_x25.c renamed from net/wan/cycx_x25.c.orig +1 -1
@@ -1446,7 +1446,7 @@
         unsigned char *ptr;
 
         if ((skb = dev_alloc_skb(1)) == NULL) {
-                printk(KERN_ERR __FUNCTION__ ": out of memory\n");
+                printk(KERN_ERR "%s: out of memory\n", __FUNCTION__);
                 return;
         }
 
#1 lore raw
Quoted 2 lines · In article <20020921112245.27021.qmail@unibar> you wrote:

This patch cleans up the __FUNCTION__ pasting to the new standard.

is this normal, that we dont have a rate limit in those functions? And even worse, that there is no error handling like signalling this back to the channel? In this case this looks especially annoying, since it is a state changing event, if when lost may totally screw up the state engine (if i understand the comment "Send event (connection, disconnection, etc) to X.25 socket layer" right.

Greetings
Bernd