Module rewrite 2/20: bigrefs
PATCH 1/1 Module rewrite 2/20: bigrefs
Name: Bigrefs Implementation
Author: Rusty Russell
Status: Tested on 2.5.38
D: This is an implementation of cache-friendly reference counts. The
D: refcounters work in two modes: the normal mode just incs and decs a
D: cache-aligned per-cpu counter. When someone is waiting for the
D: reference count to hit 0, a flag is set and a shared reference
D: counter is decremented (which is slower).
D:
D: This uses a simple non-intrusive synchronize_kernel() primitive.
include/linux/bigref.h +78 -0
@@ -0,0 +1,78 @@ +#ifndef _LINUX_BIGREF_H +#define _LINUX_BIGREF_H +#include <linux/cache.h> +#include <linux/smp.h> +#include <linux/compiler.h> +#include <linux/thread_info.h> +#include <linux/preempt.h> +#include <asm/atomic.h> + +/* Big reference counts for Linux. +* (C) Copyright 2002 Paul Russell, IBM Corporation. +*/ + +struct bigref_percpu +{ +atomic_t counter; +int slow_mode; +}____cacheline_aligned_in_smp ; + +struct bigref +{ +struct bigref_percpu ref[NR_CPUS ]; + +atomic_t slow_count; +struct task_struct *waiter; +}; + +static inline void bigref_init (struct bigref *ref,int value) +{ +unsigned int i; +atomic_set (&ref->ref[0 ].counter, value); +for (i =1 ; i <NR_CPUS ; i++) +atomic_set (&ref->ref[i].counter,0 ); + ref->waiter =NULL ;/* To trap bugs */ +} + +extern void __bigref_inc (struct bigref *ref); +extern int __bigref_dec (struct bigref *ref); + +/* We only need protection against local interrupts. */ +#ifndef __HAVE_LOCAL_INC +#define local_inc (x) atomic_inc(x) +#define local_dec (x) atomic_dec(x) +#endif + +static inline void bigref_inc (struct bigref *ref) +{ +struct bigref_percpu *cpu; + + cpu = &ref->ref[get_cpu ()]; +if (likely (!cpu->slow_mode)) +local_inc (&cpu->counter); +else +__bigref_inc (ref); +put_cpu (); +} + +/* Return true if we were the last one to decrement it */ +static inline int bigref_dec (struct bigref *ref) +{ +struct bigref_percpu *cpu; +int ret =0 ; + + cpu = &ref->ref[get_cpu ()]; +if (likely (!cpu->slow_mode)) +local_dec (&cpu->counter); +else + ret =__bigref_dec (ref); +put_cpu (); +return ret; +} + +/* Get the approximate value */ +extern int bigref_approx_val (struct bigref *ref); + +/* Wait for it refcount to hit zero (sleeps) */ +extern void bigref_wait_for_zero (struct bigref *ref); +#endif /* _LINUX_BIGREF_H */
include/linux/sched.h +2 -0
@@ -445,8 +445,10 @@ do { if (atomic_dec_and_test(&(tsk)->usa#if CONFIG_SMP extern void set_cpus_allowed (task_t *p,unsigned long new_mask); +extern void synchronize_kernel (void );#else # define set_cpus_allowed (p, new_mask) do { } while (0) +# define synchronize_kernel () do { } while (0)#endif extern void set_user_nice (task_t *p,long nice);
kernel/Makefile +2 -2
@@ -3,12 +3,12 @@ # export-objs = signal.o sys.o kmod.o context.o ksyms.o pm.o exec_domain.o \ - printk.o platform.o suspend.o dma.o + printk.o platform.o suspend.o dma.o bigref.o obj-y = sched.o fork.o exec_domain.o panic.o printk.o \ module.o exit.o itimer.o time.o softirq.o resource.o \ sysctl.o capability.o ptrace.o timer.o user.o \ - signal.o sys.o kmod.o context.o futex.o platform.o pid.o + signal.o sys.o kmod.o context.o futex.o platform.o pid.o bigref.o obj-$(CONFIG_GENERIC_ISA_DMA) += dma.o obj-$(CONFIG_SMP) += cpu.o
kernel/bigref.c +78 -0
78 lines not on this page · raw message
kernel/sched.c +44 -0
50 lines not on this page · raw message
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
include/linux/bigref.h line 32
Quoted 5 lines · On Wednesday September 25, [email protected] wrote:
include/linux/bigref.h +5
-0+static inline void bigref_init (struct bigref *ref,int value) +{ +unsigned int i; +atomic_set (&ref->ref[0 ].counter, value); +for (i =1 ; i <NR_CPUS ; i++)
-----------------^
include/linux/bigref.h line 35
Quoted 3 lines
include/linux/bigref.h +3
-0+atomic_set (&ref->ref[i].counter,0 ); + ref->waiter =NULL ;/* To trap bugs */ +}
Should this be '0', or should there be a comment explaining why it one?
NeilBrown
In message <[email protected]> you write:
Quoted 7 lines · On Wednesday September 25, [email protected] wrote:
include/linux/bigref.h line 32
Quoted 5 lines
include/linux/bigref.h +5
-0+static inline void bigref_init (struct bigref *ref,int value) +{ +unsigned int i; +atomic_set (&ref->ref[0 ].counter, value); +for (i =1 ; i <NR_CPUS ; i++)-----------------^
Quoted 6 lines
include/linux/bigref.h line 35
Quoted 3 lines
include/linux/bigref.h +3
-0+atomic_set (&ref->ref[i].counter,0 ); + ref->waiter =NULL ;/* To trap bugs */ +}Should this be '0', or should there be a comment explaining why it one?
No, if it were 0, it would overwrite the atomic_set() immediately above it. I didn't think a comment was required since this is the most obvious way to initialize a per-cpu counter to a total value.
I could add:
/* Set one to the value, the others to zero */
If you missed it, others probably will, too.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.