patch for linux/usb.h
hi there,
missing urb_t typedef
Signature · 3 lines
Regards, Wiktor Wodecki | http://johoho.eggheads.org
include/linux/usb.h +1 -1
@@ -525,7 +525,7 @@usb_complete_t complete;// pointer to completion routine // struct iso_packet_descriptor iso_frame_desc[0 ]; +} urb_t; -};/** * FILL_CONTROL_URB - macro to help initialize a control urb
include/linux/usb.h line 528
Quoted 2 lines · Wiktor Wodecki
include/linux/usb.h +1
-1+} urb_t; -};
Heh, you're kidding me, right?
No, that's not "missing" it was taken out because it should have never gotten there in the first place.
thanks,
greg k-h
Quoted 5 lines
include/linux/usb.h line 528
Quoted 2 lines
include/linux/usb.h +1
-1+} urb_t; -};No, that's not "missing" it was taken out because it should have never gotten there in the first place.
hmmm, it might "not be a good thing" to change an interface in a stable kernel series. this, for example, broke my quickcam express video cam driver. It might be wrong there, however I think we should leave it there...not apply this to 2.5 then
Signature · 3 lines
Regards, Wiktor Wodecki | http://johoho.eggheads.org
Quoted 10 lines · Wiktor Wodecki
Quoted 5 lines
include/linux/usb.h line 528
Quoted 2 lines
include/linux/usb.h +1
-1+} urb_t; -};No, that's not "missing" it was taken out because it should have never gotten there in the first place.
hmmm, it might "not be a good thing" to change an interface in a stable kernel series. this, for example, broke my quickcam express video cam driver. It might be wrong there, however I think we should leave it there...not apply this to 2.5 then
Sorry, but I fixed up all in-kernel instances of this usage. If you want to keep a driver outside of the main kernel tree, you're going to have to get used to things like this. In fact, this is a very minor change, wait until some of the other USB API changes that have happened in 2.5 get backported to 2.4 :)
Good luck,
greg k-h