Skip to contentSkip to conversation

2.5.44 - scripts/kconfig.tk error (xconfig fails)

DISCUSSION Ivan Gyurdiev 3 participants 3 messages Oct 19, 2002 Pnp support

lore
Share & tools
lore
#0 lore raw

drivers/pnp/Config.in: 7: can't handle dep_bool/dep_mbool/dep_tristate condition
wish -f scripts/kconfig.tk
Error in startup script: invalid command name "clear_choices"
while executing
"clear_choices"
(procedure "read_config" line 3)
invoked from within
"read_config $defaults"
invoked from within

"if { [file readable .config] == 1} then {
        if { $argc > 0 } then {
                if { [lindex $argv 0] != "-D" } then {
                        read_config .config
                }
                else
                {
                        r..."
    (file "scripts/kconfig.tk" line 646)

make: *** [xconfig] Error 1

#1 lore raw
Quoted 5 lines · Ivan Gyurdiev

drivers/pnp/Config.in: 7: can't handle dep_bool/dep_mbool/dep_tristate condition
wish -f scripts/kconfig.tk
Error in startup script: invalid command name "clear_choices"
...

A dep_bool without a dependency is wrong. The following patch fixes it:

drivers/pnp/Config.in renamed from drivers/pnp/Config.in.old +1 -1
@@ -4,7 +4,7 @@
 mainmenu_option next_comment
 comment 'Plug and Play configuration'
 
-dep_bool 'Plug and Play support' CONFIG_PNP
+bool 'Plug and Play support' CONFIG_PNP
 
    dep_bool '  Plug and Play device name database' CONFIG_PNP_NAMES $CONFIG_PNP
    dep_bool '  PnP Debug Messages' CONFIG_PNP_DEBUG $CONFIG_PNP

cu
Adrian

Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
                                Pearl S. Buck - Dragon Seed
#2 lore raw

Hi,

Quoted 1 line · Adrian Bunk

A dep_bool without a dependency is wrong. The following patch fixes it:

It's not the only error. 'comment' doesn't accept dependencies (correct fix attached).
(No, we have no new syntax yet. *sigh*)

bye, Roman

Index: drivers/pnp/Config.in
===================================================================
RCS file: /usr/src/cvsroot/linux-2.5/drivers/pnp/Config.in,v retrieving revision 1.1.1.3

pnp/Config.in +9 -7
diff -u -p -r1.1.1.3 Config.in
@@ -4,15 +4,17 @@
 mainmenu_option next_comment
 comment 'Plug and Play configuration'
 
-dep_bool 'Plug and Play support' CONFIG_PNP
+bool 'Plug and Play support' CONFIG_PNP
 
-   dep_bool '  Plug and Play device name database' CONFIG_PNP_NAMES $CONFIG_PNP
-   dep_bool '  PnP Debug Messages' CONFIG_PNP_DEBUG $CONFIG_PNP
+if [ "$CONFIG_PNP" = "y" ]; then
+   bool '  Plug and Play device name database' CONFIG_PNP_NAMES
+   bool '  PnP Debug Messages' CONFIG_PNP_DEBUG
 
-comment 'Protocols' $CONFIG_PNP
+   comment 'Protocols'
 
-if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
-   dep_bool '  ISA Plug and Play support (EXPERIMENTAL)' CONFIG_ISAPNP $CONFIG_PNP
-   dep_bool '  Plug and Play BIOS support (EXPERIMENTAL)' CONFIG_PNPBIOS $CONFIG_PNP
+   if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then
+      bool '  ISA Plug and Play support (EXPERIMENTAL)' CONFIG_ISAPNP
+      bool '  Plug and Play BIOS support (EXPERIMENTAL)' CONFIG_PNPBIOS
+   fi
 fi
 endmenu