Skip to contentSkip to conversation

patches to policy question

DISCUSSION Tom 3 participants 7 messages Oct 29, 2002 SELinux security module

lore
Share & tools
lore

Tom

author
#0 lore raw

I've posted a few patches against Russell's default policy, but I've started to wonder about the general workflow.

Is Russell's policy worked into the NSA CVS, so the workflow would be 3rd Part -> Russell -> NSA ?
Or would it be better if I (or anyone else) would also diff changes against the latest NSA release and post those patches?

Is posting here the right way to submit patches anyway?

Signature · 8 lines
PGP/GPG key: http://web.lemuria.org/pubkey.html
pub  1024D/2D7A04F5 2002-05-16 Tom Vogt <[email protected]>
     Key fingerprint = C731 64D1 4BCF 4C20 48A4  29B2 BF01 9FA1 2D7A 04F5

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to [email protected] with
the words "unsubscribe selinux" without quotes as the message.
#1 lore raw
Quoted 9 lines · Tom

I've posted a few patches against Russell's default policy, but I've started to wonder about the general workflow.

Is Russell's policy worked into the NSA CVS, so the workflow would be 3rd Part -> Russell -> NSA ?
Or would it be better if I (or anyone else) would also diff changes against the latest NSA release and post those patches?

Is posting here the right way to submit patches anyway?

I regularly post patches here that get merged into the NSA tree.

If you are working based on my tree then sending the patches to me may be easiest for you. Also if you are working on something that I am working on or have recently worked on then it may be easiest for everyone if you send the patches to me.

But sending patches to the list which apply against the CVS will also work.

Posting patches here is the right way IMHO.

Signature · 10 lines
http://www.coker.com.au/selinux/   My NSA Security Enhanced Linux packages
http://www.coker.com.au/bonnie++/  Bonnie++ hard drive benchmark
http://www.coker.com.au/postal/    Postal SMTP/POP benchmark
http://www.coker.com.au/~russell/  My home page


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to [email protected] with
the words "unsubscribe selinux" without quotes as the message.
#2 lore raw
In reply to Tom
Quoted 9 lines · Tom

I've posted a few patches against Russell's default policy, but I've started to wonder about the general workflow.

Is Russell's policy worked into the NSA CVS, so the workflow would be 3rd Part -> Russell -> NSA ?
Or would it be better if I (or anyone else) would also diff changes against the latest NSA release and post those patches?

Is posting here the right way to submit patches anyway?

Yes, posting here is the right way to submit patches. Russell does submit policy patches to us for merging, but we also consider other directly submitted policy patches. A diff against the sourceforge selinux CVS tree is optimal for us, but may not always be reasonable for Debian selinux users if the Debian policy deviates too much.

--
Stephen D. Smalley, NAI Labs
[email protected]

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.

author
#3 lore raw
Quoted 5 lines

Yes, posting here is the right way to submit patches. Russell does submit policy patches to us for merging, but we also consider other directly submitted policy patches. A diff against the sourceforge selinux CVS tree is optimal for us, but may not always be reasonable for Debian selinux users if the Debian policy deviates too much.

Great. Should I repost my Subversion policy or has it been considered already? I believe it is finished, while I'm still working on apache and mysql and will submit more refined versions of those in the future.

(Subversion is a CVS replacement, i.e. an advanced revision control system.)

Signature · 8 lines
PGP/GPG key: http://web.lemuria.org/pubkey.html
pub  1024D/2D7A04F5 2002-05-16 Tom Vogt <[email protected]>
     Key fingerprint = C731 64D1 4BCF 4C20 48A4  29B2 BF01 9FA1 2D7A 04F5

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to [email protected] with
the words "unsubscribe selinux" without quotes as the message.
#4 lore raw
Quoted 6 lines · Tom

Great. Should I repost my Subversion policy or has it been considered already? I believe it is finished, while I'm still working on apache and mysql and will submit more refined versions of those in the future.

(Subversion is a CVS replacement, i.e. an advanced revision control system.)

Unless it has changed since your last posting, you don't need to repost. It is in the queue for review.

--
Stephen D. Smalley, NAI Labs
[email protected]

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.

#6 lore raw
In reply to Stephen Smalley
Quoted 5 lines · Stephen Smalley

Yes, posting here is the right way to submit patches. Russell does submit policy patches to us for merging, but we also consider other directly submitted policy patches. A diff against the sourceforge selinux CVS tree is optimal for us, but may not always be reasonable for Debian selinux users if the Debian policy deviates too much.

You can be certain that I'll incorporate everything from the CVS into my tree at the time of the next release (if not before).

Also when patches are posted against the CVS I often merge them, but it sometimes depends on how interested I am in that area and whether it's something I think can wait for the next release.

Also there was one occasion that I refused a patch and advised the author to try Steve because I would never accept it otherwise.

Signature · 10 lines
http://www.coker.com.au/selinux/   My NSA Security Enhanced Linux packages
http://www.coker.com.au/bonnie++/  Bonnie++ hard drive benchmark
http://www.coker.com.au/postal/    Postal SMTP/POP benchmark
http://www.coker.com.au/~russell/  My home page


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to [email protected] with
the words "unsubscribe selinux" without quotes as the message.
author
#5 lore raw
In reply to Stephen Smalley
Quoted 2 lines · Stephen Smalley

Unless it has changed since your last posting, you don't need to repost. It is in the queue for review.

No, version from 25th is still current.

Signature · 8 lines
PGP/GPG key: http://web.lemuria.org/pubkey.html
pub  1024D/2D7A04F5 2002-05-16 Tom Vogt <[email protected]>
     Key fingerprint = C731 64D1 4BCF 4C20 48A4  29B2 BF01 9FA1 2D7A 04F5

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to [email protected] with
the words "unsubscribe selinux" without quotes as the message.