2.5.45 build failed with ACPI turned on
Hi
Build fails with:
drivers/acpi/sleep.c: In function `acpi_system_suspend':drivers/acpi/sleep.c:209: warning: implicit declaration of function do_suspend_lowlevel' drivers/acpi/sleep.c: In function acpi_sleep_init':drivers/acpi/sleep.c:707: `sysrq_acpi_poweroff_op' undeclared (first use in this function) drivers/acpi/sleep.c:707: (Each undeclared identifier is reported only once drivers/acpi/sleep.c:707: for each function it appears in.)
The structure declaration is protected by
#if defined(CONFIG_MAGIC_SYSRQ) && defined(CONFIG_PM)
on line 640.
Config file attached.
Signature · 4 lines
Kind regards, Robert Varga ------------------------------------------------------------------------------ [email protected] http://hq.sk/~nite/gpgkey.txt
Quoted 5 lines · Robert Varga
The structure declaration is protected by
#if
defined(CONFIG_MAGIC_SYSRQ)&&defined(CONFIG_PM)on line 640.
At the moment CONFIG_PM seems to be enabling APM, though it clearly does more than that. I think the config options for ACPI and APM should be sorted out sooner or later. Just enable Power Management and this should compile.
Jos
After some more puzzling, it becomes clear that much more ACPI code should rely on CONFIG_PM. (Sleep.c should not be compiled in at all without CONFIG_PM) As the ACPI guys seem awake, I assume this will be fixed soon. For now: don't forget to enable CONFIG_PM (Power Management in the root of ACPI / APM configuration)
Jos
Quoted 19 lines · Robert Varga
Hi
Build fails with:
drivers/acpi/sleep.c: In function `acpi_system_suspend':drivers/acpi/sleep.c:209: warning: implicit declaration of functiondo_suspend_lowlevel' drivers/acpi/sleep.c: In functionacpi_sleep_init':drivers/acpi/sleep.c:707: `sysrq_acpi_poweroff_op' undeclared (first use in this function)drivers/acpi/sleep.c:707: (Each undeclared identifier is reported only oncedrivers/acpi/sleep.c:707: for each function it appears in.)The structure declaration is protected by
#if
defined(CONFIG_MAGIC_SYSRQ)&&defined(CONFIG_PM)on line 640.
Config file attached.