2.5.45 / fb vga16fb build error

gcc -Wp,-MD,drivers/video/.vga16fb.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -Iarch/i386/mach-generic -nostdinc -iwithprefix include -DKBUILD_BASENAME=vga16fb -c -o drivers/video/vga16fb.o drivers/video/vga16fb.c drivers/video/vga16fb.c: In function `vga16fb_set_disp':
drivers/video/vga16fb.c:177: structure has no member named `visual'
drivers/video/vga16fb.c:178: structure has no member named `type'
drivers/video/vga16fb.c:179: structure has no member named `type_aux'
drivers/video/vga16fb.c:180: structure has no member named `ypanstep'
drivers/video/vga16fb.c:181: structure has no member named `ywrapstep'
drivers/video/vga16fb.c:182: structure has no member named `line_length'
drivers/video/vga16fb.c: In function `vga_vesa_blank':
drivers/video/vga16fb.c:664: warning: implicit declaration of function `cli'
drivers/video/vga16fb.c:671: warning: implicit declaration of function `sti'
drivers/video/vga16fb.c: At top level:
drivers/video/vga16fb.c:814: unknown field `fb_get_fix' specified in initializer
drivers/video/vga16fb.c:814: warning: initialization from incompatible pointer type
drivers/video/vga16fb.c:815: unknown field `fb_get_var' specified in initializer
drivers/video/vga16fb.c:815: warning: initialization from incompatible pointer type
make[2]: *** [drivers/video/vga16fb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

FB .config section:

#
# Frame-buffer support
#
CONFIG_FB=y
CONFIG_DUMMY_CONSOLE=y
# CONFIG_FB_CLGEN is not set
# CONFIG_FB_PM2 is not set
# CONFIG_FB_CYBER2000 is not set
# CONFIG_FB_ATY is not set
CONFIG_FB_VGA16=y
CONFIG_FB_VESA=y
# CONFIG_FB_HGA is not set
# CONFIG_FB_RIVA is not set
# CONFIG_FB_MATROX is not set
# CONFIG_FB_RADEON is not set
# CONFIG_FB_ATY128 is not set
# CONFIG_FB_SIS is not set
# CONFIG_FB_NEOMAGIC is not set
# CONFIG_FB_3DFX is not set
# CONFIG_FB_VOODOO1 is not set
# CONFIG_FB_TRIDENT is not set
# CONFIG_FB_PM3 is not set
# CONFIG_FB_VIRTUAL is not set
# CONFIG_FBCON_ADVANCED is not set
CONFIG_FBCON_CFB24=y
CONFIG_FBCON_ACCEL=y
CONFIG_FBCON_VGA_PLANES=y
# CONFIG_FBCON_FONTWIDTH8_ONLY is not set
# CONFIG_FBCON_FONTS is not set
CONFIG_FONT_8x8=y
CONFIG_FONT_8x16=y

Only mod to the source was a patch to let me use menuconfig without having the qt devel setup.

        All people are equal,
        But some are more equal then others.
            - George W. Bush Jr, President of the United States
              September 21, 2002 (Abridged version of security speech)

[...]

I posted a fix for this a while ago (perhaps a week or two ago). I think Alan Cox picked it up but it may not have made it into any Linus kernel yet.

"In this world that Hugh Heffner had made,
 he alone seemed forever bunnyless."
--John D. MacDonald

I finished porting over the driver to the new api last night. It will be part of the next pull by Linus. I have a few more things I need done over the weekend for the new fbdev stuff.

Was there something wrong with my patches to do the same thing that have been in Alan Cox's tree for some time now?

No, but the final api is done and struct display_switch is going away!!! So I had to fix the driver to work with the latest changes.

I see. I didn't realize that the API was changing again. Oh well.

"Now I have to go wash my mind out with soap."
--Derick Siddoway

Its the last set of changes. It should be ready monday.

Hey.

Any news wrt this? :)

        All people are equal,
        But some are more equal then others.
            - George W. Bush Jr, President of the United States
              September 21, 2002 (Abridged version of security speech)

I will be posting a patch today against 2.5.48. It will have the latest changes for the fbdev layer. Note several drivers are still broken but I'm in the process of updating them over the next few days :-)