Skip to contentSkip to conversation

get rid of ->init in osst

PATCH In review Christoph Hellwig 2 participants 2 messages Nov 3, 2002 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 get rid of ->init in osst

Since osst is the last driver still implementing ->init and Willem said he's gonna do a major update including a resync with st anyway I think it's okay to put this hack in for now. Instead of ->init beeing directly called from the midlayer osst_attach now calls in in the beginning - it has an internal protection so that the initialization will be called only one anyway.

drivers/scsi/osst.c +2 -1
@@ -163,7 +163,6 @@
        tag:		"osst",
        scsi_type:	TYPE_TAPE,
        detect:		osst_detect,
-       init:		osst_init,
        attach:		osst_attach,
        detach:		osst_detach
 };
@@ -5410,6 +5409,8 @@
 
 	if (SDp->type != TYPE_TAPE || !osst_supports(SDp))
 		 return 1;
+
+	osst_init();
 
 	disk = alloc_disk(1);
 	if (!disk)
#1 lore raw
Quoted 20 lines · On 2002.11.03 15:54 Christoph Hellwig wrote:

Since osst is the last driver still implementing ->init and Willem said he's gonna do a major update including a resync with st anyway I think it's okay to put this hack in for now. Instead of ->init beeing directly called from the midlayer osst_attach now calls in in the beginning - it has an internal protection so that the initialization will be called only one anyway.

drivers/scsi/osst.c +0 -1
@@ -163,7 +163,6 @@
        tag:		"osst",
        scsi_type:	TYPE_TAPE,
        detect:		osst_detect,
-       init:		osst_init,
        attach:		osst_attach,
        detach:		osst_detach
 };

drivers/scsi/osst.c line 5416

Quoted 8 lines
drivers/scsi/osst.c +2 -0
@@ -5410,6 +5409,8 @@
 
 	if (SDp->type != TYPE_TAPE || !osst_supports(SDp))
 		 return 1;
+
+	osst_init();
 
 	disk = alloc_disk(1);
 	if (!disk)

That's fine. I'm debugging that major update as we speak :-)

Regards, Willem Riede.