Skip to contentSkip to conversation

Printout improvements in ide-tape

PATCH Pete Zaitcev 1 participant 1 message Dec 14, 2002

lore
Share & tools
lore
#0 lore raw

This one changes printouts only. It is not as important as the one I sent before it, but it was very helpful in debugging. I think we better have this one too.

-- Pete

drivers/ide/ide-tape.c +7 -9
@@ -2165,11 +2163,6 @@
 			status.b.check = 0;
 		if (status.b.check || test_bit(PC_DMA_ERROR, &pc->flags)) {
 			/* Error detected */
-#if IDETAPE_DEBUG_LOG
-			if (tape->debug_level >= 1)
-				printk(KERN_INFO "ide-tape: %s: I/O error\n",
-					tape->name);
-#endif /* IDETAPE_DEBUG_LOG */
 			if (pc->c[0] == IDETAPE_REQUEST_SENSE_CMD) {
 				printk(KERN_ERR "ide-tape: I/O error in "
 					"request sense command\n");
@@ -2270,8 +2263,8 @@
 	pc->current_position += bcount.all;
 #if IDETAPE_DEBUG_LOG
 	if (tape->debug_level >= 2)
-		printk(KERN_INFO "ide-tape: [cmd %x] transferred %d bytes "
-			"on that interrupt\n", pc->c[0], bcount.all);
+		printk(KERN_INFO "ide-tape: [cmd %x] done %d\n"
+			pc->c[0], bcount.all);
 #endif
 	if (HWGROUP(drive)->handler != NULL)
 		BUG();
@@ -2614,8 +2607,11 @@
 	if (status.b.dsc) {
 		if (status.b.check) {
 			/* Error detected */
-			printk(KERN_ERR "ide-tape: %s: I/O error, ",
-					tape->name);
+			printk(KERN_ERR "ide-tape: %s: I/O error: "
+			    "pc = %2x, key = %2x, asc = %2x, ascq = %2x\n",
+			    tape->name, pc->c[0],
+			    tape->sense_key, tape->asc, tape->ascq);
+
 			/* Retry operation */
 			return idetape_retry_pc(drive);
 		}