Skip to contentSkip to conversation

Linux 2.2.24-rc1

DISCUSSION Alan Cox 5 participants 7 messages Dec 16, 2002 – Dec 19, 2002

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

Linux 2.2.24-rc1

o Fix a typo in the maintainers (James Morris)
o Dave Niemi has moved (Dave Niemi)
o Fix incorrect blocking on nonblock pipe (Pete Benie)
o Fix misidentification of some AMD processors (Bruce Robson)
o Fix a very obscure skb_realloc_headroom bug (James Morris)
o Fix warning in lance driver (Thomas Cort)
o Fix sign handling bug in pms driver (Silvio Cesare)
o Drop mmap on /proc/<pid>/mem as 2.4/2.5 did (Michal Zalewski)
(also fixes some bugs)

#1 lore raw
Quoted 1 line · Alan Cox

Linux 2.2.24-rc1

[...]

Quoted 1 line

o Fix misidentification of some AMD processors (Bruce Robson)

[...]

Is it the following chunk? (I can't find anything more appropriate) @@ -1378,7 +1378,8 @@

                        return;

                case X86_VENDOR_AMD:
-                       init_amd(c);
+                       if(init_amd(c))
+                               return;
                        return;

                case X86_VENDOR_CENTAUR:

What does it fix?

pkot

Signature · 2 lines
mailto:[email protected] :: mailto:[email protected]
http://kt.linuxnews.pl/ :: Kernel Traffic po polsku
#2 lore raw
Quoted 8 lines · Pawel Kot

case X86_VENDOR_AMD:

(quoted diff) +2 -1
-                       init_amd(c);
+                       if(init_amd(c))
+                               return;
                        return;
 
                case X86_VENDOR_CENTAUR:

What does it fix?

If we get a vendor string, we should use it - thats all

#3 lore raw
Quoted 11 lines · Alan Cox
Quoted 8 lines · Pawel Kot

case X86_VENDOR_AMD:

(quoted diff) +2 -1
-                       init_amd(c);
+                       if(init_amd(c))
+                               return;
                        return;
 
                case X86_VENDOR_CENTAUR:

What does it fix?

If we get a vendor string, we should use it - thats all

This patch also makes us unconditionally skip the mcheck_init if we have a vendor string. That doesn't seem right.

Dave

Signature · 2 lines
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
#4 lore raw
Quoted 4 lines · Dave Jones
Quoted 1 line

If we get a vendor string, we should use it - thats all

This patch also makes us unconditionally skip the mcheck_init if we have a vendor string. That doesn't seem right.

True.. ok its more complicated to fix 8(

#5 lore raw
In reply to Pawel Kot
Quoted 13 lines · Pawel Kot

Is it the following chunk? (I can't find anything more appropriate)

(quoted diff) +2 -1
@@ -1378,7 +1378,8 @@
                       return;
 
               case X86_VENDOR_AMD:
-                       init_amd(c);
+                       if(init_amd(c))
+                               return;
                       return;
 
               case X86_VENDOR_CENTAUR:

What does it fix?

Quoted 3 lines

pkot

i assume there was more to the patch?

i mean first it did init_amd(c) and then return
now it does init_amd(c) and returns in the if or right on the next line, so that's the same with extra bloat.

confused,

Robert Boermans.

author
#6 lore raw
Quoted 1 line

i assume there was more to the patch?

Well no. Its just I got it slightly wrong 8)