2.4.21-pre2-jp15
Quoted 2 lines
drivers/char/char.o: In function `sysrq_handle_preempt_log':
drivers/char/char.o(.text+0x1c79e): undefined reference to `show_preempt_log'
Please apply
http://infolinux.de/jp15/076_sysrq-preempt-log-fix
Patchset .bz2 archive will be updated.
Jörg
drivers/char/sysrq.c renamed from drivers/char/sysrq.c.orig +1 -1
@@ -27,7 +27,7 @@#include <linux/quotaops.h> #include <linux/smp_lock.h> #include <linux/module.h> - +#include <linux/sched.h> #include <linux/spinlock.h> #include <asm/ptrace.h>
Hi Jörg,
Sorry, the patch doesn't change anything.
I am compiling with PREEMPT off.
Looking at sysrq.c , I would say that a couple of #ifdef's are missing. The code in the handle_preempt function, I think should be ifdef'd on CONFIG_PREEMPT_LOG
Margit
Quoted 24 lines · you
Quoted 2 lines
drivers/char/char.o: In function `sysrq_handle_preempt_log':
drivers/char/char.o(.text+0x1c79e): undefined reference to`show_preempt_log'
Please apply
http://infolinux.de/jp15/076_sysrq-preempt-log-fix
Patchset .bz2 archive will be updated.
Jörg
--- linux-jp15/drivers/char/sysrq.c.orig 2002-12-30
19:48:15.000000000 +0100
+++linux-jp15/drivers/char/sysrq.c2002-12-30 19:48:35.000000000 +0100drivers/char/sysrq.c renamed from drivers/char/sysrq.c.orig +1
-1@@ -27,7 +27,7 @@#include <linux/quotaops.h> #include <linux/smp_lock.h> #include <linux/module.h> - +#include <linux/sched.h> #include <linux/spinlock.h> #include <asm/ptrace.h>
Quoted 7 lines
Sorry, the patch doesn't change anything.
I am compiling with PREEMPT off.
Looking atsysrq.c, I would say that a couple of #ifdef's are missing. The code in thehandle_preemptfunction, I think should be ifdef'd onCONFIG_PREEMPT_LOGMargit
Hi Margit,
you should enable preemptive kernel logging only if you selected preemptive kernel.
In the case of preempt logging turned off, the show_preempt_log() function should evaluate to an empty function
#define show_preempt_log() do { } while(0)
as defined in <linux/sched.h>
Best regards,
Jörg