cpufreq: remove deprecated usage of CPUFREQ_ALL_CPUS in ACPI
PATCH 1/1 cpufreq: remove deprecated usage of CPUFREQ_ALL_CPUS in ACPI
As policy->cpu now only points to an existing CPU, some code can safely be removed from the ACPI P-States cpufreq driver.
Dominik
drivers/acpi/processor.c +15 -48
@@ -1669,24 +1669,10 @@if (!policy)return_VALUE (-EINVAL ); -/* get a present, initialized CPU */ -if (policy->cpu ==CPUFREQ_ALL_CPUS ) - { -for (i=0 ; i<NR_CPUS ; i++) { -if (processors[i] !=NULL ) { - cpu = i; - pr = processors[cpu]; -break ; - } - } - } -else - { - cpu = policy->cpu; - pr = processors[cpu]; -if (!pr) -return_VALUE (-EINVAL ); - } + cpu = policy->cpu; + pr = processors[cpu]; +if (!pr) +return_VALUE (-EINVAL );/* select appropriate P-State */ if (policy->policy ==CPUFREQ_POLICY_POWERSAVE )
@@ -1715,19 +1701,9 @@ }/* set one or all CPUs to the new state */ -if (policy->cpu ==CPUFREQ_ALL_CPUS ) { -for (i=0 ; i<NR_CPUS ; i++) - { - pr = processors[cpu]; -if (!pr || !cpu_online (cpu)) -continue ; - result =acpi_processor_set_performance (pr, next_state); - } - }else { - result =acpi_processor_set_performance (pr, next_state); - } + result =acpi_processor_set_performance (pr, next_state); -return_VALUE (0 ); +return_VALUE (result); }
@@ -1746,24 +1722,10 @@if (!policy)return_VALUE (-EINVAL ); -/* get a present, initialized CPU */ -if (policy->cpu ==CPUFREQ_ALL_CPUS ) - { -for (i=0 ; i<NR_CPUS ; i++) { -if (processors[i] !=NULL ) { - cpu = i; - pr = processors[cpu]; -break ; - } - } - } -else - { - cpu = policy->cpu; - pr = processors[cpu]; -if (!pr) -return_VALUE (-EINVAL ); - } + cpu = policy->cpu; + pr = processors[cpu]; +if (!pr) +return_VALUE (-EINVAL );/* first check if min and max are within valid limits */ cpufreq_verify_within_limits(
@@ -1787,6 +1749,11 @@ policy->max = pr->performance.states[next_larger_state].core_frequency *1000 ; } +cpufreq_verify_within_limits ( + policy, + pr->performance.states[pr->performance.state_count -1 ].core_frequency *1000 , + pr->performance.states[pr->limit.state.px].core_frequency *1000 ); +return_VALUE (0 ); }