Skip to contentSkip to conversation

PATCH: add hwclock ioctls used in 2.4 for pa and in 2.5

PATCH Geert Uytterhoeven 1 participant 2 messages Jan 4, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 28 lines · Linux Kernel Mailing List

ChangeSet 1.925, 2003/01/02 21:03:29-02:00, [email protected]

[PATCH] PATCH: add hwclock ioctls used in 2.4 for pa and in 2.5

# This patch includes the following deltas:
# ChangeSet 1.924 -> 1.925
# include/linux/kd.h 1.3 -> 1.4
#

 kd.h |   13 +++++++++++++
 1 files changed, 13 insertions(+)

diff -Nru a/include/linux/kd.h b/include/linux/kd.h

include/linux/kd.h +6 -0
@@ -132,6 +132,19 @@
 
 #define KDSIGACCEPT	0x4B4E	/* accept kbd generated signals */
 
+struct hwclk_time {
+	unsigned	sec;	/* 0..59 */
+	unsigned	min;	/* 0..59 */
+	unsigned	hour;	/* 0..23 */
+	unsigned	day;	/* 1..31 */
+	unsigned	mon;	/* 0..11 */

include/linux/kd.h line 150

Quoted 10 lines
include/linux/kd.h +7 -0
+	unsigned	year;	/* 70... */
+	int		wday;	/* 0..6, 0 is Sunday, -1 means unknown/don't set */
+};
+
+#define KDGHWCLK        0x4B50	/* get hardware clock */
+#define KDSHWCLK        0x4B51  /* set hardware clock */
+
 struct kbd_repeat {
 	int delay;	/* in msec; <= 0: don't change */
 	int rate;	/* in msec; <= 0: don't change */

Ugh, and I was so happy to have them removed in 2.4.19 :-( BTW, they were removed from 2.5.x in 2.5.15 as well.

ChangeSet log was:

| - Kill m68k-specific struct hwclk_time in favor of common struct rtc_time
| - Kill m68k-specific KD[GS]HWCLK ioctls() (the code for them was removed a
|   long time ago)

Wouldn't it be better to convert PA-RISC to use struct rtc_time as well?

And the KD[GS]HWCLK ioctl()s are obsolete anyway, use /dev/rtc to access the hardware clock. On PA-RISC that should be done through genrtc, which I'm in the process of cleaning up for submission to marcelo.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw
In reply to a message not in the archive
Quoted 28 lines · Linux Kernel Mailing List

ChangeSet 1.925, 2003/01/02 21:03:29-02:00, [email protected]

[PATCH] PATCH: add hwclock ioctls used in 2.4 for pa and in 2.5

# This patch includes the following deltas:
# ChangeSet 1.924 -> 1.925
# include/linux/kd.h 1.3 -> 1.4
#

 kd.h |   13 +++++++++++++
 1 files changed, 13 insertions(+)

diff -Nru a/include/linux/kd.h b/include/linux/kd.h

include/linux/kd.h +6 -0
@@ -132,6 +132,19 @@
 
 #define KDSIGACCEPT	0x4B4E	/* accept kbd generated signals */
 
+struct hwclk_time {
+	unsigned	sec;	/* 0..59 */
+	unsigned	min;	/* 0..59 */
+	unsigned	hour;	/* 0..23 */
+	unsigned	day;	/* 1..31 */
+	unsigned	mon;	/* 0..11 */

include/linux/kd.h line 150

Quoted 10 lines
include/linux/kd.h +7 -0
+	unsigned	year;	/* 70... */
+	int		wday;	/* 0..6, 0 is Sunday, -1 means unknown/don't set */
+};
+
+#define KDGHWCLK        0x4B50	/* get hardware clock */
+#define KDSHWCLK        0x4B51  /* set hardware clock */
+
 struct kbd_repeat {
 	int delay;	/* in msec; <= 0: don't change */
 	int rate;	/* in msec; <= 0: don't change */

Ugh, and I was so happy to have them removed in 2.4.19 :-( BTW, they were removed from 2.5.x in 2.5.15 as well.

ChangeSet log was:

| - Kill m68k-specific struct hwclk_time in favor of common struct rtc_time
| - Kill m68k-specific KD[GS]HWCLK ioctls() (the code for them was removed a
|   long time ago)

Wouldn't it be better to convert PA-RISC to use struct rtc_time as well?

And the KD[GS]HWCLK ioctl()s are obsolete anyway, use /dev/rtc to access the hardware clock. On PA-RISC that should be done through genrtc, which I'm in the process of cleaning up for submission to marcelo.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds