Skip to contentSkip to conversation

Another idea for simplifying locking in kernel/module.c

DISCUSSION Adam J. Richter 2 participants 2 messages Jan 7, 2003 – Jan 9, 2003

lore
Share & tools
lore

Adam J. Richter

author
#0 lore raw
Quoted 6 lines · I wrote:

Here is a way to replace all of the specialized "stop CPU"
locking code in kernel/module.c with an rw_semaphore by using down_read_trylock in try_module_get() and down_write when beginning to unload the module.

The following UNTESTED patch, a net deletion of 136 lines,

I am running that patch now on two computers. It seems to
be OK.

Rusty, I'd be interested in knowing what you think of the
patch (likewise for other lkml readers).

Adam J. Richter     __     ______________   575 Oroville Road
[email protected]     \ /                  Milpitas, California 95035
+1 408 309-6081         | g g d r a s i l   United States of America

"Free Software For The Rest Of Us."

#1 lore raw
Quoted 6 lines · Adam J. Richter
Quoted 5 lines · I wrote:

Here is a way to replace all of the specialized "stop CPU"
locking code in kernel/module.c with an rw_semaphore by using down_read_trylock in try_module_get() and down_write when beginning to unload the module.

Quoted 7 lines
Quoted 1 line

The following UNTESTED patch, a net deletion of 136 lines,

I am running that patch now on two computers. It seems to
be OK.

Rusty, I'd be interested in knowing what you think of the
patch (likewise for other lkml readers).

We have to be able to call try_module_get() from interrupt context.

Max