small fix for nforce ide chipset driver in 2.5.54

I recently acquired an Epox 8RDA motherboard, which uses the Nforce2 chipset. While trying to compile 2.5.54 I ran across an error in drivers/ide/pci/nvidia.c. Several times the define PCI_DEVICE_ID_NVIDIA_NFORCE_IDE is referenced, but is not defined anywhere. It seems it is missing from include/linux/pci_ids.h. On my board it shows up as:

00:09.0 IDE interface: nVidia Corporation: Unknown device 0065 (rev a2) (prog-if 8a [Master SecP PriP])

so I added a #define for PCI_DEVICE_ID_NVIDIA_NFORCE_IDE as 0x0065. It compiled fine and I am in fact running that kernel now. I would have just sent a patch but I am new to kernel hacking, this is just a one liner and I'm sure you know where it goes better than I do.

thanks, James

James Curbo <[email protected]> <[email protected]>

Someone deleted it about 2.5.50, and though I sent in the fix twice Linus still hasn't applied it 8(

Well, I thought this deal was over but apparently not. My 2.5.54 kernel is still working fine, but when I compiled 2.4.20-ac2, it didn't pick up my Nforce2 IDE. On a whim I checked include/linux/pci_ids.h and it has a different PCI ID for PCI_DEVICE_ID_NVIDIA_NFORCE_IDE, namely 0x01bc. (lspci -v reports 0x0065 here). Perhaps 0x01bc is the nforce1 ide chipset and 0x0065 is the nforce2 ide chipset?

James Curbo <[email protected]> <[email protected]>
GPG public key available at http://sandwich.net/~phoenix/keys/

2.4.21pre3-ac2 should support the Nforce and Nforce2. Its not the final driver for 2.4 or 2.5 (there is a much nicer merged AMD/Nvidia one) but it will wait until after 2.4.21 before I merge it.